From: mhagger@alum.mit.edu
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Drew Northup <drew.northup@maine.edu>,
Jakub Narebski <jnareb@gmail.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
Johan Herland <johan@herland.net>,
Julian Phillips <julian@quantumfyre.co.uk>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH v2 05/14] clear_ref_array(): rename from free_ref_array()
Date: Mon, 17 Oct 2011 09:39:14 +0200 [thread overview]
Message-ID: <1318837163-27112-6-git-send-email-mhagger@alum.mit.edu> (raw)
In-Reply-To: <1318837163-27112-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>
Rename the function since it doesn't actually free the array object
that is passed to it.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
refs.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index 87c8913..30e505a 100644
--- a/refs.c
+++ b/refs.c
@@ -149,7 +149,7 @@ static struct ref_entry *current_ref;
static struct ref_array extra_refs;
-static void free_ref_array(struct ref_array *array)
+static void clear_ref_array(struct ref_array *array)
{
int i;
for (i = 0; i < array->nr; i++)
@@ -162,14 +162,14 @@ static void free_ref_array(struct ref_array *array)
static void clear_packed_ref_cache(struct ref_cache *refs)
{
if (refs->did_packed)
- free_ref_array(&refs->packed);
+ clear_ref_array(&refs->packed);
refs->did_packed = 0;
}
static void clear_loose_ref_cache(struct ref_cache *refs)
{
if (refs->did_loose)
- free_ref_array(&refs->loose);
+ clear_ref_array(&refs->loose);
refs->did_loose = 0;
}
@@ -256,7 +256,7 @@ void add_extra_ref(const char *refname, const unsigned char *sha1, int flag)
void clear_extra_refs(void)
{
- free_ref_array(&extra_refs);
+ clear_ref_array(&extra_refs);
}
static struct ref_array *get_packed_refs(const char *submodule)
--
1.7.7.rc2
next prev parent reply other threads:[~2011-10-17 7:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 7:39 [PATCH v2 00/14] Tidying up references code mhagger
2011-10-17 7:39 ` [PATCH v2 01/14] cache.h: add comments for git_path() and git_path_submodule() mhagger
2011-10-17 7:39 ` [PATCH v2 02/14] struct ref_entry: document name member mhagger
2011-10-17 7:39 ` [PATCH v2 03/14] refs: rename "refname" variables mhagger
2011-10-17 7:39 ` [PATCH v2 04/14] refs: rename parameters result -> sha1 mhagger
2011-10-17 7:39 ` mhagger [this message]
2011-10-17 7:39 ` [PATCH v2 06/14] is_refname_available(): remove the "quiet" argument mhagger
2011-10-17 7:39 ` [PATCH v2 07/14] parse_ref_line(): add docstring mhagger
2011-10-17 7:39 ` [PATCH v2 08/14] add_ref(): " mhagger
2011-10-17 7:39 ` [PATCH v2 09/14] is_dup_ref(): extract function from sort_ref_array() mhagger
2011-10-17 7:39 ` [PATCH v2 10/14] refs: change signatures of get_packed_refs() and get_loose_refs() mhagger
2011-10-17 7:39 ` [PATCH v2 11/14] get_ref_dir(): change signature mhagger
2011-10-17 7:39 ` [PATCH v2 12/14] resolve_gitlink_ref(): improve docstring mhagger
2011-10-17 7:39 ` [PATCH v2 13/14] Pass a (ref_cache *) to the resolve_gitlink_*() helper functions mhagger
2011-10-17 7:39 ` [PATCH v2 14/14] resolve_gitlink_ref_recursive(): change to work with struct ref_cache mhagger
2011-10-17 19:12 ` [PATCH v2 00/14] Tidying up references code Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318837163-27112-6-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=drew.northup@maine.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jnareb@gmail.com \
--cc=johan@herland.net \
--cc=julian@quantumfyre.co.uk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).