From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH 1/6] revert: free msg in format_todo()
Date: Thu, 20 Oct 2011 02:33:23 +0530 [thread overview]
Message-ID: <1319058208-17923-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1319058208-17923-1-git-send-email-artagnon@gmail.com>
Memory allocated to the fields of msg by get_message() isn't freed.
This is potentially a big leak, because fresh memory is allocated to
store the commit message for each commit. Fix this using
free_message().
Reported-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin/revert.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin/revert.c b/builtin/revert.c
index 010508d..94b7c50 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -680,6 +680,7 @@ static int format_todo(struct strbuf *buf, struct commit_list *todo_list,
if (get_message(cur->item, &msg))
return error(_("Cannot get commit message for %s"), sha1_abbrev);
strbuf_addf(buf, "%s %s %s\n", action_str, sha1_abbrev, msg.subject);
+ free_message(&msg);
}
return 0;
}
--
1.7.6.351.gb35ac.dirty
next prev parent reply other threads:[~2011-10-19 21:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 21:03 [PATCH v2 0/6] Sequencer fixups mini-series Ramkumar Ramachandra
2011-10-19 21:03 ` Ramkumar Ramachandra [this message]
2011-10-19 21:03 ` [PATCH 2/6] revert: simplify getting commit subject in format_todo() Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 3/6] revert: fix buffer overflow in insn sheet parser Ramkumar Ramachandra
2011-10-20 1:30 ` Junio C Hamano
2011-10-20 8:03 ` Jonathan Nieder
2011-10-20 8:48 ` Ramkumar Ramachandra
2011-10-20 9:09 ` Jonathan Nieder
2011-10-20 15:36 ` Ramkumar Ramachandra
2011-10-20 17:15 ` Junio C Hamano
2011-10-20 18:05 ` Jonathan Nieder
2011-10-20 18:55 ` Junio C Hamano
2011-10-22 18:57 ` Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 4/6] revert: make commit subjects in insn sheet optional Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 5/6] revert: allow mixed pick and revert instructions Ramkumar Ramachandra
2011-10-19 21:03 ` [PATCH 6/6] revert: simplify communicating command-line arguments Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319058208-17923-2-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).