From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v4 0/5] Signed-commit
Date: Wed, 19 Oct 2011 17:36:58 -0700 [thread overview]
Message-ID: <1319071023-31919-1-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1318983645-18897-1-git-send-email-gitster@pobox.com>
The fourth iteration.
- The first patch refactors where the current code invokes gpg for
signing and verification of tags;
- The second patch introduces signed commit objects (unchanged);
- The third patch teaches "git log/show" to show the signature (adjusted
to the updated "gpg output capture" API, with colors);
- The fourth patch refactors helper bits to test GPG related features
out of existing "tag -s" && "tag --verify" test script (new); and
- The fifth patch adds tests for "commit [--amend] -S", "merge -S",
and "show --show-signature" (new).
I think the internal API to drive "gpg" in this iteration is good to go.
The verification side has been updated to allow the callers to capture
output from GPG in a strbuf, so that they can pretty-print it in a format
more suitable in their context, rather than just spewing it out to the
standard error stream.
Junio C Hamano (5):
Split GPG interface into its own helper library
commit: teach --gpg-sign option
log: --show-signature
t7004: extract generic "GPG testing" bits
test "commit -S" and "log --show-signature"
Makefile | 2 +
builtin/commit-tree.c | 24 +++++++-
builtin/commit.c | 12 +++-
builtin/merge.c | 16 +++++-
builtin/tag.c | 76 ++-----------------------
builtin/verify-tag.c | 35 ++----------
commit.c | 74 ++++++++++++++++++++++++-
commit.h | 5 +-
gpg-interface.c | 138 ++++++++++++++++++++++++++++++++++++++++++++++
gpg-interface.h | 10 +++
log-tree.c | 39 +++++++++++++
notes-cache.c | 2 +-
notes-merge.c | 2 +-
revision.c | 2 +
revision.h | 1 +
t/lib-gpg.sh | 29 ++++++++++
t/lib-gpg/pubring.gpg | Bin 0 -> 1164 bytes
t/lib-gpg/random_seed | Bin 0 -> 600 bytes
t/lib-gpg/secring.gpg | Bin 0 -> 1237 bytes
t/lib-gpg/trustdb.gpg | Bin 0 -> 1280 bytes
t/t7004-tag.sh | 29 +---------
t/t7004/pubring.gpg | Bin 1164 -> 0 bytes
t/t7004/random_seed | Bin 600 -> 0 bytes
t/t7004/secring.gpg | Bin 1237 -> 0 bytes
t/t7004/trustdb.gpg | Bin 1280 -> 0 bytes
t/t7510-signed-commit.sh | 60 ++++++++++++++++++++
tag.c | 5 ++
27 files changed, 422 insertions(+), 139 deletions(-)
create mode 100644 gpg-interface.c
create mode 100644 gpg-interface.h
create mode 100644 t/lib-gpg.sh
create mode 100644 t/lib-gpg/pubring.gpg
create mode 100644 t/lib-gpg/random_seed
create mode 100644 t/lib-gpg/secring.gpg
create mode 100644 t/lib-gpg/trustdb.gpg
delete mode 100644 t/t7004/pubring.gpg
delete mode 100644 t/t7004/random_seed
delete mode 100644 t/t7004/secring.gpg
delete mode 100644 t/t7004/trustdb.gpg
create mode 100755 t/t7510-signed-commit.sh
--
1.7.7.498.g3f2e50
next prev parent reply other threads:[~2011-10-20 0:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 0:56 [PATCH] commit: teach --gpg-sign option Junio C Hamano
2011-10-06 15:50 ` Shawn Pearce
2011-10-06 17:11 ` Jonathan Nieder
2011-10-06 17:22 ` Matthieu Moy
2011-10-06 18:44 ` Michael J Gruber
2011-10-06 21:29 ` Junio C Hamano
2011-10-06 22:24 ` Robin H. Johnson
2011-10-07 8:40 ` Michael J Gruber
2011-10-07 11:18 ` Nguyen Thai Ngoc Duy
2011-10-09 16:32 ` Michael J Gruber
2011-10-09 22:57 ` Robin H. Johnson
2011-10-09 23:18 ` Junio C Hamano
2011-10-11 0:38 ` Robin H. Johnson
2011-10-09 20:00 ` Michael J Gruber
2011-10-09 21:22 ` Junio C Hamano
2011-10-10 6:33 ` Michael J Gruber
2011-10-10 16:35 ` Junio C Hamano
2011-10-09 22:27 ` Junio C Hamano
2011-10-10 6:33 ` Michael J Gruber
2011-10-10 16:45 ` Junio C Hamano
2011-10-11 6:39 ` Michael J Gruber
[not found] ` <CACBZZX6xsnAv4S8zAqi08bcqrghZ8nKdzFP=UNCqZOqrEeLFnA@mail.gmail.com>
2011-10-10 4:58 ` Junio C Hamano
2011-10-19 0:20 ` [PATCH v3 0/3] Signed-commit Junio C Hamano
2011-10-19 0:20 ` [PATCH v3 1/3] Split GPG interface into its own helper library Junio C Hamano
2011-10-19 0:20 ` [PATCH v3 2/3] commit: teach --gpg-sign option Junio C Hamano
2011-10-19 0:20 ` [PATCH v3 3/3] log: --show-signature Junio C Hamano
2011-10-20 0:36 ` Junio C Hamano [this message]
2011-10-20 0:36 ` [PATCH v4 1/5] Split GPG interface into its own helper library Junio C Hamano
2011-10-20 0:37 ` [PATCH v4 2/5] commit: teach --gpg-sign option Junio C Hamano
2011-10-20 0:37 ` [PATCH v4 3/5] log: --show-signature Junio C Hamano
2011-10-20 0:37 ` [PATCH v4 4/5] t7004: extract generic "GPG testing" bits Junio C Hamano
2011-10-20 0:37 ` [PATCH v4 5/5] test "commit -S" and "log --show-signature" Junio C Hamano
2011-10-22 5:01 ` [PATCH 7/5] pretty: %G[?GS] placeholders Junio C Hamano
2011-10-22 10:47 ` Elia Pinto
2011-10-22 17:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319071023-31919-1-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).