* [PATCH] Fix 'Cloning into' message
@ 2011-10-26 17:05 Richard Hartmann
2011-10-27 16:46 ` Richard Hartmann
0 siblings, 1 reply; 4+ messages in thread
From: Richard Hartmann @ 2011-10-26 17:05 UTC (permalink / raw)
To: git; +Cc: Richard Hartmann
Without this patch,
git clone foo .
results in this:
Cloning into ....
done.
With it:
Cloning into '.'...
done.
---
builtin/clone.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 488f48e..efe8b6c 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -577,9 +577,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
if (0 <= option_verbosity) {
if (option_bare)
- printf(_("Cloning into bare repository %s...\n"), dir);
+ printf(_("Cloning into bare repository '%s'...\n"), dir);
else
- printf(_("Cloning into %s...\n"), dir);
+ printf(_("Cloning into '%s'...\n"), dir);
}
init_db(option_template, INIT_DB_QUIET);
write_config(&option_config);
--
1.7.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] Fix 'Cloning into' message
2011-10-26 17:05 [PATCH] Fix 'Cloning into' message Richard Hartmann
@ 2011-10-27 16:46 ` Richard Hartmann
2011-10-27 17:39 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Richard Hartmann @ 2011-10-27 16:46 UTC (permalink / raw)
To: git, gitster; +Cc: Richard Hartmann
Without this patch,
git clone foo .
results in this:
Cloning into ....
done.
With it:
Cloning into '.'...
done.
Signed-off-by: Richard Hartmann <richih.mailinglist@gmail.com>
---
builtin/clone.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 488f48e..efe8b6c 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -577,9 +577,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
if (0 <= option_verbosity) {
if (option_bare)
- printf(_("Cloning into bare repository %s...\n"), dir);
+ printf(_("Cloning into bare repository '%s'...\n"), dir);
else
- printf(_("Cloning into %s...\n"), dir);
+ printf(_("Cloning into '%s'...\n"), dir);
}
init_db(option_template, INIT_DB_QUIET);
write_config(&option_config);
--
1.7.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fix 'Cloning into' message
2011-10-27 16:46 ` Richard Hartmann
@ 2011-10-27 17:39 ` Junio C Hamano
2011-10-27 18:34 ` Richard Hartmann
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2011-10-27 17:39 UTC (permalink / raw)
To: Richard Hartmann; +Cc: git
Richard Hartmann <richih.mailinglist@gmail.com> writes:
> Without this patch,
>
> git clone foo .
>
> results in this:
>
> Cloning into ....
> done.
>
> With it:
>
> Cloning into '.'...
> done.
>
> Signed-off-by: Richard Hartmann <richih.mailinglist@gmail.com>
We try to be consistent and many places do quote user supplied paths in
pair of single quotes in human readable messages, and this is in line with
that pattern.
$ git clone foo "joey's foo"
would result in
Cloning into 'joey's foo'...
but that is probably Ok ;-)
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix 'Cloning into' message
2011-10-27 17:39 ` Junio C Hamano
@ 2011-10-27 18:34 ` Richard Hartmann
0 siblings, 0 replies; 4+ messages in thread
From: Richard Hartmann @ 2011-10-27 18:34 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Thu, Oct 27, 2011 at 19:39, Junio C Hamano <gitster@pobox.com> wrote:
> We try to be consistent and many places do quote user supplied paths in
> pair of single quotes in human readable messages, and this is in line with
> that pattern.
Exactly. That is why I chose single quotes. Sorry for not including
the signed-off the first time.
> $ git clone foo "joey's foo"
In that case, the user has other problems ;)
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-27 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-26 17:05 [PATCH] Fix 'Cloning into' message Richard Hartmann
2011-10-27 16:46 ` Richard Hartmann
2011-10-27 17:39 ` Junio C Hamano
2011-10-27 18:34 ` Richard Hartmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).