git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent van Ravesteijn <vfr@lyx.org>
To: git@vger.kernel.org
Cc: kusmabite@gmail.com, ramsay@ramsay1.demon.co.uk,
	msysgit@googlegroups.com, gitster@pobox.com,
	Vincent van Ravesteijn <vfr@lyx.org>
Subject: [PATCH 1/3] Compile fix for MSVC: Do not include sys/resources.h
Date: Mon, 31 Oct 2011 20:12:42 +0100	[thread overview]
Message-ID: <1320088364-25916-2-git-send-email-vfr@lyx.org> (raw)
In-Reply-To: <1320088364-25916-1-git-send-email-vfr@lyx.org>

Do not include header files when compiling with MSVC that do not
exist and which are also not included when compiling with MINGW.
A direct consequence is that git can be compiled again with MSVC
because the missing "sys/resources.h" is no longer included.

Instead of current

	#ifndef mingw32 is the only one that is strange
        ... everything for systems that is not strange ...
        #else
        ... include mingw specific tweaks ...
        #endif
        #ifdef msvc is also strange
        ... include msvc specific tweaks ...
        #endif

it turns things around and says what it wants to achieve in a more direct
way, i.e.

	#if mingw32
        #include "compat/mingw.h"
	#elif msvc
        #include "compat/msvc.h"
	#else
        ... all the others ...
	#endif

which makes it look simpler.

Signed-off-by: Vincent van Ravesteijn <vfr@lyx.org>
Helped-by: Junio C Hamano <gitster@pobox.com>
---
 git-compat-util.h |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/git-compat-util.h b/git-compat-util.h
index 5ef8ff7..53186da 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -116,7 +116,12 @@
 #else
 #include <poll.h>
 #endif
-#ifndef __MINGW32__
+#if defined(__MINGW32__)
+/* pull in Windows compatibility stuff */
+#include "compat/mingw.h"
+#elif defined(_MSC_VER)
+#include "compat/msvc.h"
+#else
 #include <sys/wait.h>
 #include <sys/resource.h>
 #include <sys/socket.h>
@@ -145,12 +150,6 @@
 #include <grp.h>
 #define _ALL_SOURCE 1
 #endif
-#else 	/* __MINGW32__ */
-/* pull in Windows compatibility stuff */
-#include "compat/mingw.h"
-#endif	/* __MINGW32__ */
-#ifdef _MSC_VER
-#include "compat/msvc.h"
 #endif
 
 #ifndef NO_LIBGEN_H
-- 
1.7.4.1

  reply	other threads:[~2011-10-31 19:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 19:12 [PATCHv2] Compile fix for MSVC Vincent van Ravesteijn
2011-10-31 19:12 ` Vincent van Ravesteijn [this message]
2011-10-31 19:12 ` [PATCH 2/3] Compile fix for MSVC: Include <io.h> Vincent van Ravesteijn
2011-10-31 19:12 ` [PATCH 3/3] MSVC: Remove unneeded header stubs Vincent van Ravesteijn
2011-10-31 20:34 ` [PATCHv2] Compile fix for MSVC Junio C Hamano
2011-11-01  0:09   ` [msysGit] " Johannes Schindelin
2011-11-01  3:30     ` Junio C Hamano
2011-11-01 11:56     ` Erik Faye-Lund
2011-11-01 16:45       ` Junio C Hamano
2011-11-01 20:35         ` Erik Faye-Lund
2011-11-01 20:47           ` Junio C Hamano
2011-11-01 18:40       ` Johannes Schindelin
2011-11-01 20:43         ` Erik Faye-Lund
2011-11-01 22:51           ` [msysGit] " Johannes Schindelin
2011-11-01 22:32         ` Vincent van Ravesteijn
2011-11-01 22:40           ` [msysGit] " Johannes Schindelin
2011-11-01 23:33             ` Vincent van Ravesteijn
2011-11-02  0:48           ` [msysGit] " Pat Thoyts
2011-11-02  7:34             ` Vincent van Ravesteijn
2011-11-04 15:39             ` Sebastian Schuberth
2011-11-01  0:36   ` Erik Faye-Lund
2011-11-01  3:30     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320088364-25916-2-git-send-email-vfr@lyx.org \
    --to=vfr@lyx.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kusmabite@gmail.com \
    --cc=msysgit@googlegroups.com \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).