git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH 2/5] sequencer: remove CHERRY_PICK_HEAD with sequencer state
Date: Sat,  5 Nov 2011 21:59:43 +0530	[thread overview]
Message-ID: <1320510586-3940-3-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1320510586-3940-1-git-send-email-artagnon@gmail.com>

Make remove_sequencer_state() remove '.git/CHERRY_PICK_HEAD' when
invoked aggressively, since we want to treat it as part of the
sequencer state now.  While at it, make some minor improvements to the
function.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 sequencer.c |   27 ++++++++++++++++-----------
 1 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/sequencer.c b/sequencer.c
index 87f146b..e566043 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -25,17 +25,22 @@ static char *get_encoding(const char *message);
 
 void remove_sequencer_state(int aggressive)
 {
-	struct strbuf seq_dir = STRBUF_INIT;
-	struct strbuf seq_old_dir = STRBUF_INIT;
-
-	strbuf_addf(&seq_dir, "%s", git_path(SEQ_DIR));
-	strbuf_addf(&seq_old_dir, "%s", git_path(SEQ_OLD_DIR));
-	remove_dir_recursively(&seq_old_dir, 0);
-	rename(git_path(SEQ_DIR), git_path(SEQ_OLD_DIR));
-	if (aggressive)
-		remove_dir_recursively(&seq_old_dir, 0);
-	strbuf_release(&seq_dir);
-	strbuf_release(&seq_old_dir);
+	const char *seq_dir = git_path(SEQ_DIR);
+	const char *seq_old_dir = git_path(SEQ_OLD_DIR);
+	const char *cherry_pick_head = git_path("CHERRY_PICK_HEAD");
+	struct strbuf seq_dir_buf = STRBUF_INIT;
+	struct strbuf seq_old_dir_buf = STRBUF_INIT;
+
+	strbuf_addf(&seq_dir_buf, "%s", seq_dir);
+	strbuf_addf(&seq_old_dir_buf, "%s", seq_old_dir);
+	remove_dir_recursively(&seq_old_dir_buf, 0);
+	rename(seq_dir, seq_old_dir);
+	if (aggressive) {
+		remove_dir_recursively(&seq_old_dir_buf, 0);
+		unlink(cherry_pick_head);
+	}
+	strbuf_release(&seq_dir_buf);
+	strbuf_release(&seq_old_dir_buf);
 }
 
 struct commit_message {
-- 
1.7.6.351.gb35ac.dirty

  parent reply	other threads:[~2011-11-05 16:31 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-05 16:29 [PATCH 0/5] Sequencer: working around historical mistakes Ramkumar Ramachandra
2011-11-05 16:29 ` [PATCH 1/5] sequencer: factor code out of revert builtin Ramkumar Ramachandra
2011-11-06  0:12   ` Jonathan Nieder
2011-11-13 10:40     ` Ramkumar Ramachandra
2011-11-13 23:10       ` Junio C Hamano
2011-11-15  9:00         ` Ramkumar Ramachandra
2011-11-15  9:18           ` Miles Bader
2011-11-15  9:47             ` Jonathan Nieder
2011-11-05 16:29 ` Ramkumar Ramachandra [this message]
2011-11-06  0:15   ` [PATCH 2/5] sequencer: remove CHERRY_PICK_HEAD with sequencer state Jonathan Nieder
2011-11-05 16:29 ` [PATCH 3/5] sequencer: sequencer state is useless without todo Ramkumar Ramachandra
2011-11-06  0:26   ` Jonathan Nieder
2011-11-13 10:44     ` Ramkumar Ramachandra
2011-11-13 20:50       ` Junio C Hamano
2011-11-15  9:13         ` Ramkumar Ramachandra
2011-11-15  9:52           ` Jonathan Nieder
2011-11-15 16:27             ` Junio C Hamano
2011-11-16  6:17               ` Ramkumar Ramachandra
2011-11-16  7:38                 ` Junio C Hamano
2011-11-16  7:59                 ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Jonathan Nieder
2011-11-16  8:03                   ` [PATCH 1/3] do not let git_path clobber errno when reporting errors Jonathan Nieder
2011-11-16  8:04                   ` [PATCH 2/3] Bigfile: dynamically allocate buffer for marks file name Jonathan Nieder
2011-11-16  8:07                   ` [PATCH 3/3] rename git_path() to git_path_unsafe() Jonathan Nieder
2011-11-17  1:20                     ` Junio C Hamano
2011-11-17  7:03                       ` Jonathan Nieder
2011-11-16  8:37                   ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Nguyen Thai Ngoc Duy
2011-11-16  8:42                     ` Nguyen Thai Ngoc Duy
2011-11-16  8:59                     ` Jonathan Nieder
2011-11-16  9:31                       ` Nguyen Thai Ngoc Duy
2011-11-19 19:25                         ` Ramsay Jones
2011-11-16 21:50                       ` [PATCH/RFC] introduce strbuf_addpath() Jonathan Nieder
2011-11-18  1:42                         ` Nguyen Thai Ngoc Duy
2011-11-16 22:04                     ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Junio C Hamano
2011-11-16  8:51                   ` Ramkumar Ramachandra
2011-11-16 13:33                   ` Nguyen Thai Ngoc Duy
2011-11-16 13:44                     ` Michael Haggerty
2011-11-18  3:33                   ` Nguyen Thai Ngoc Duy
2011-11-05 16:29 ` [PATCH 4/5] sequencer: handle single commit pick separately Ramkumar Ramachandra
2011-11-06  0:35   ` Jonathan Nieder
2011-11-05 16:29 ` [PATCH 5/5] sequencer: revert d3f4628e Ramkumar Ramachandra
2011-11-06  0:42   ` Jonathan Nieder
2011-11-06 19:10     ` Junio C Hamano
2011-11-07  6:06       ` Ramkumar Ramachandra
2011-11-12 16:13     ` Ramkumar Ramachandra
2011-11-12 22:40       ` Jonathan Nieder
2011-11-05 23:43 ` [PATCH 0/5] Sequencer: working around historical mistakes Jonathan Nieder
2011-11-13 10:42   ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320510586-3940-3-git-send-email-artagnon@gmail.com \
    --to=artagnon@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).