From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 5/6] parse-options: allow OPTION_ARGUMENT to take argument
Date: Thu, 10 Nov 2011 14:12:34 +0700 [thread overview]
Message-ID: <1320909155-4575-5-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <1320909155-4575-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
parse-options.c | 18 +++++++++++++++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/parse-options.c b/parse-options.c
index 58bb83d..3a1575a 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -218,11 +218,23 @@ static int parse_long_opt(struct parse_opt_ctx_t *p, const char *arg,
if (options->type == OPTION_ARGUMENT) {
if (!rest)
continue;
- if (*rest == '=')
- return opterror(options, "takes no value", flags);
+ if (*rest == '=') {
+ if (options->flags & PARSE_OPT_NOARG)
+ return opterror(options, "takes no value", flags);
+ p->out[p->cpidx++] = *p->argv;
+ return 0;
+ }
+
if (*rest)
continue;
- p->out[p->cpidx++] = arg - 2;
+ p->out[p->cpidx++] = *p->argv;
+ if (!(options->flags & PARSE_OPT_NOARG)) {
+ p->argv++;
+ p->argc--;
+ if (!*p->argv)
+ return opterror(options, "takes no value", flags);
+ p->out[p->cpidx++] = *p->argv;
+ }
return 0;
}
if (!rest) {
--
1.7.4.74.g639db
next prev parent reply other threads:[~2011-11-10 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 7:12 [PATCH 1/6] Print trace in rev-list machinery Nguyễn Thái Ngọc Duy
2011-11-10 7:12 ` [PATCH 2/6] find_pack_entry(): do not keep packed_git pointer locally Nguyễn Thái Ngọc Duy
2011-11-10 7:12 ` [PATCH 3/6] parse-options: add OPT_ULONG Nguyễn Thái Ngọc Duy
2011-11-10 7:12 ` [PATCH 4/6] pack-objects: use parse_options() Nguyễn Thái Ngọc Duy
2011-11-10 7:12 ` Nguyễn Thái Ngọc Duy [this message]
2011-11-10 7:12 ` [PATCH 6/6] Build in git-repack Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320909155-4575-5-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).