* [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.
@ 2011-11-18 18:13 Samuel Bronson
2011-11-30 0:02 ` Samuel Bronson
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Bronson @ 2011-11-18 18:13 UTC (permalink / raw)
To: git; +Cc: Pat Thoyts, Shawn O. Pearce, Samuel Bronson
It would be better if the 32x32 icon was equivalent to the one used on
Windows (in git-gui.ico), but I'm not sure how that would best be done,
so I copied this code from gitk instead.
---
git-gui.sh | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index c190cbe..9d01039 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -729,7 +729,12 @@ if {[is_Windows]} {
gitlogo put gray26 -to 5 15 11 16
gitlogo redither
- wm iconphoto . -default gitlogo
+ # TODO: should use something equivalent to the 32x32 image in
+ # the .ico file
+ image create photo gitlogo32 -width 32 -height 32
+ gitlogo32 copy gitlogo -zoom 2 2
+
+ wm iconphoto . -default gitlogo gitlogo32
}
}
--
1.7.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.
2011-11-18 18:13 [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming Samuel Bronson
@ 2011-11-30 0:02 ` Samuel Bronson
2011-12-07 14:36 ` Pat Thoyts
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Bronson @ 2011-11-30 0:02 UTC (permalink / raw)
To: git; +Cc: Pat Thoyts, Shawn O. Pearce, Samuel Bronson
On Fri, Nov 18, 2011 at 1:13 PM, Samuel Bronson <naesten@gmail.com> wrote:
> It would be better if the 32x32 icon was equivalent to the one used on
> Windows (in git-gui.ico), but I'm not sure how that would best be done,
> so I copied this code from gitk instead.
> ---
> git-gui.sh | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index c190cbe..9d01039 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -729,7 +729,12 @@ if {[is_Windows]} {
> gitlogo put gray26 -to 5 15 11 16
> gitlogo redither
>
> - wm iconphoto . -default gitlogo
> + # TODO: should use something equivalent to the 32x32 image in
> + # the .ico file
> + image create photo gitlogo32 -width 32 -height 32
> + gitlogo32 copy gitlogo -zoom 2 2
> +
> + wm iconphoto . -default gitlogo gitlogo32
> }
> }
Hmm. Nothing seems to have happened with this patch yet. Any
suggestions on how to bring it to the attention of the git-gui people?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming.
2011-11-30 0:02 ` Samuel Bronson
@ 2011-12-07 14:36 ` Pat Thoyts
0 siblings, 0 replies; 3+ messages in thread
From: Pat Thoyts @ 2011-12-07 14:36 UTC (permalink / raw)
To: Samuel Bronson; +Cc: git, Shawn O. Pearce
Samuel Bronson <naesten@gmail.com> writes:
>
>Hmm. Nothing seems to have happened with this patch yet. Any
>suggestions on how to bring it to the attention of the git-gui people?
I got around to checking this with xmingw and it makes sense so it's
committed now.
Thanks.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-07 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 18:13 [PATCH] git-gui: Set both 16x16 and 32x32 icons on X to pacify Xming Samuel Bronson
2011-11-30 0:02 ` Samuel Bronson
2011-12-07 14:36 ` Pat Thoyts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).