From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Subject: [PATCH 2/2] t3401: use test_commit in setup
Date: Fri, 9 Dec 2011 08:59:12 -0800 [thread overview]
Message-ID: <1323449952-14161-2-git-send-email-martin.von.zweigbergk@gmail.com> (raw)
In-Reply-To: <1323449952-14161-1-git-send-email-martin.von.zweigbergk@gmail.com>
Simplify t3401 by using test_commit in the setup. This lets us refer
to commits using their tags and there is no longer a need to create
the branch my-topic-branch-merge. Also, the branch master-merge points
to the same commit as master (even before this change), so that branch
does not need to be created either.
Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
---
t/t3401-rebase-partial.sh | 31 ++++++++-----------------------
1 files changed, 8 insertions(+), 23 deletions(-)
diff --git a/t/t3401-rebase-partial.sh b/t/t3401-rebase-partial.sh
index d7c874c..1aac22c 100755
--- a/t/t3401-rebase-partial.sh
+++ b/t/t3401-rebase-partial.sh
@@ -12,32 +12,17 @@ local branch.
. ./test-lib.sh
test_expect_success 'prepare repository with topic branch' '
- echo First > A &&
- git update-index --add A &&
- git commit -m "Add A." &&
-
+ test_commit A &&
git checkout -b my-topic-branch &&
-
- echo Second > B &&
- git update-index --add B &&
- git commit -m "Add B." &&
-
- echo AnotherSecond > C &&
- git update-index --add C &&
- git commit -m "Add C." &&
-
+ test_commit B &&
+ test_commit C &&
git checkout -f master &&
-
- echo Third >> A &&
- git update-index A &&
- git commit -m "Modify A."
+ test_commit A2 A.t
'
test_expect_success 'pick top patch from topic branch into master' '
- git cherry-pick my-topic-branch^0 &&
- git checkout -f my-topic-branch &&
- git branch master-merge master &&
- git branch my-topic-branch-merge my-topic-branch
+ git cherry-pick C &&
+ git checkout -f my-topic-branch
'
test_debug '
@@ -52,8 +37,8 @@ test_expect_success 'rebase topic branch against new master and check git am did
'
test_expect_success 'rebase --merge topic branch that was partially merged upstream' '
- git checkout -f my-topic-branch-merge &&
- git rebase --merge master-merge &&
+ git reset --hard C &&
+ git rebase --merge master &&
test ! -d .git/rebase-merge
'
--
1.7.8.237.gcc4e3
next prev parent reply other threads:[~2011-12-09 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 16:59 [PATCH 1/2] t3401: modernize style Martin von Zweigbergk
2011-12-09 16:59 ` Martin von Zweigbergk [this message]
2011-12-09 19:02 ` [PATCH 2/2] t3401: use test_commit in setup Ramkumar Ramachandra
2011-12-09 19:57 ` Jonathan Nieder
2011-12-09 18:51 ` [PATCH 1/2] t3401: modernize style Ramkumar Ramachandra
2011-12-09 20:07 ` Jonathan Nieder
2011-12-10 8:14 ` Martin von Zweigbergk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323449952-14161-2-git-send-email-martin.von.zweigbergk@gmail.com \
--to=martin.von.zweigbergk@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).