From: Pete Wyckoff <pw@padd.com>
To: git@vger.kernel.org
Cc: Gary Gibbons <ggibbons@perforce.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 1/4] git-p4: ensure submit clientPath exists before chdir
Date: Fri, 9 Dec 2011 18:48:14 -0500 [thread overview]
Message-ID: <1323474497-14339-2-git-send-email-pw@padd.com> (raw)
In-Reply-To: <1323474497-14339-1-git-send-email-pw@padd.com>
From: Gary Gibbons <ggibbons@perforce.com>
Submitting patches back to p4 requires a p4 "client". This
is a mapping from server depot paths into a local directory.
The directory need not exist or be populated with files; only
the mapping on the server is required. When there is no
directory, make git-p4 automatically create it.
[ reword description --pw ]
Signed-off-by: Gary Gibbons <ggibbons@perforce.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
---
contrib/fast-import/git-p4 | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index b975d67..99d3abe 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1099,6 +1099,10 @@ class P4Submit(Command, P4UserMap):
print "Perforce checkout for depot path %s located at %s" % (self.depotPath, self.clientPath)
self.oldWorkingDirectory = os.getcwd()
+ # ensure the clientPath exists
+ if not os.path.exists(self.clientPath):
+ os.makedirs(self.clientPath)
+
chdir(self.clientPath)
print "Synchronizing p4 checkout..."
p4_sync("...")
--
1.7.8.rc4.42.g8317d
next prev parent reply other threads:[~2011-12-09 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 23:48 [PATCH 0/4] git-p4: paths for p4 Pete Wyckoff
2011-12-09 23:48 ` Pete Wyckoff [this message]
2011-12-09 23:48 ` [PATCH 2/4] git-p4: submit test for auto-creating clientPath Pete Wyckoff
2011-12-09 23:48 ` [PATCH 3/4] git-p4: use absolute directory for PWD env var Pete Wyckoff
2011-12-09 23:48 ` [PATCH 4/4] git-p4: test for absolute PWD problem Pete Wyckoff
2011-12-12 5:14 ` [PATCH 0/4] git-p4: paths for p4 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323474497-14339-2-git-send-email-pw@padd.com \
--to=pw@padd.com \
--cc=ggibbons@perforce.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).