From: Joe Ratterman <jratt0@gmail.com>
To: git@vger.kernel.org
Cc: Joe Ratterman <jratt0@gmail.com>
Subject: [PATCH] Gitweb: Avoid warnings when a repo does not have a valid HEAD
Date: Tue, 13 Dec 2011 16:35:05 -0600 [thread overview]
Message-ID: <1323815706-10560-1-git-send-email-jratt0@gmail.com> (raw)
It is possible that the HEAD reference does not point to an existing
branch. When viewing such a repository in gitweb, a message like this
one was sent to the error log:
gitweb.cgi: Use of uninitialized value in string eq at /usr/src/git/gitweb/gitweb.cgi line 5115.
Signed-off-by: Joe Ratterman <jratt0@gmail.com>
---
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4f0c3bd..5af06d6 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5440,7 +5440,7 @@ sub git_heads_body {
for (my $i = $from; $i <= $to; $i++) {
my $entry = $headlist->[$i];
my %ref = %$entry;
- my $curr = $ref{'id'} eq $head;
+ my $curr = $head ? ($ref{'id'} eq $head) : 0;
if ($alternate) {
print "<tr class=\"dark\">\n";
} else {
--
1.7.7.1
next reply other threads:[~2011-12-13 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 22:35 Joe Ratterman [this message]
2011-12-13 22:35 ` [PATCH] Add '-P' as a synonym for '--no-pager' in the git command Joe Ratterman
2011-12-14 7:44 ` Johannes Sixt
2011-12-14 8:22 ` [PATCH] test: errors preparing for a test are not special Jonathan Nieder
2011-12-14 8:51 ` Johannes Sixt
2011-12-14 9:00 ` Jonathan Nieder
2011-12-14 8:53 ` [PATCH] Gitweb: Avoid warnings when a repo does not have a valid HEAD Jonathan Nieder
-- strict thread matches above, loose matches on Subject: below --
2011-12-15 20:58 Joe Ratterman
2011-12-15 22:02 ` Junio C Hamano
2011-12-15 22:28 ` Junio C Hamano
2011-12-16 14:55 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323815706-10560-1-git-send-email-jratt0@gmail.com \
--to=jratt0@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).