From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Elijah Newren" <newren@gmail.com>,
"Jason Evans" <jasone@canonware.com>,
"David Barr" <david.barr@cordelta.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH 4/4] Suppress "statement not reached" warnings under Sun Studio
Date: Wed, 21 Dec 2011 01:18:22 +0000 [thread overview]
Message-ID: <1324430302-22441-5-git-send-email-avarab@gmail.com> (raw)
In-Reply-To: <1324430302-22441-1-git-send-email-avarab@gmail.com>
Sun Studio 12 Update 1's brain will melt on these two occurances of
using "goto" to jump into a loop. It'll emit these warnings:
"read-cache.c", line 761: warning: statement not reached (E_STATEMENT_NOT_REACHED)
"xdiff/xutils.c", line 194: warning: statement not reached (E_STATEMENT_NOT_REACHED)
Suppress these warnings by using a Sun Studio specific pragma
directive to turn them off, but only do so if __sun is defined, which
is the macro Sun Studio uses to identify itself under both its C and
C++ variants, see http://developers.sun.com/sunstudio/products/faqs/cpp.html
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
read-cache.c | 6 ++++++
xdiff/xutils.c | 6 ++++++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/read-cache.c b/read-cache.c
index a51bba1..0a4e895 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -758,7 +758,13 @@ int verify_path(const char *path)
return 0;
goto inside;
+#ifdef __sun
+# pragma error_messages (off, E_STATEMENT_NOT_REACHED)
+#endif
for (;;) {
+#ifdef __sun
+# pragma error_messages (on, E_STATEMENT_NOT_REACHED)
+#endif
if (!c)
return 1;
if (is_dir_sep(c)) {
diff --git a/xdiff/xutils.c b/xdiff/xutils.c
index 0de084e..62c3567 100644
--- a/xdiff/xutils.c
+++ b/xdiff/xutils.c
@@ -191,7 +191,13 @@ int xdl_recmatch(const char *l1, long s1, const char *l2, long s2, long flags)
*/
if (flags & XDF_IGNORE_WHITESPACE) {
goto skip_ws;
+#ifdef __sun
+# pragma error_messages (off, E_STATEMENT_NOT_REACHED)
+#endif
while (i1 < s1 && i2 < s2) {
+#ifdef __sun
+# pragma error_messages (on, E_STATEMENT_NOT_REACHED)
+#endif
if (l1[i1++] != l2[i2++])
return 0;
skip_ws:
--
1.7.7.3
next prev parent reply other threads:[~2011-12-21 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 1:18 [PATCH 0/4] Eliminate warnings under Sun Studio Ævar Arnfjörð Bjarmason
2011-12-21 1:18 ` [PATCH 1/4] Fix an enum assignment issue spotted by " Ævar Arnfjörð Bjarmason
2011-12-21 1:18 ` [PATCH 2/4] Fix a bitwise negation " Ævar Arnfjörð Bjarmason
2011-12-21 1:18 ` [PATCH 3/4] Appease Sun Studio by renaming "tmpfile" Ævar Arnfjörð Bjarmason
2011-12-21 1:18 ` Ævar Arnfjörð Bjarmason [this message]
2011-12-21 18:27 ` [PATCH 4/4] Suppress "statement not reached" warnings under Sun Studio Junio C Hamano
2011-12-21 19:03 ` Ævar Arnfjörð Bjarmason
2011-12-21 20:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324430302-22441-5-git-send-email-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jasone@canonware.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).