From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= Subject: [PATCH 3/3] index-pack: eliminate unlimited recursion in get_delta_base() Date: Mon, 26 Dec 2011 19:04:40 +0700 Message-ID: <1324901080-23215-3-git-send-email-pclouds@gmail.com> References: <1324901080-23215-1-git-send-email-pclouds@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Junio C Hamano , "Shawn O. Pearce" , =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Dec 26 13:02:08 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rf9Fn-0003c6-0F for gcvg-git-2@lo.gmane.org; Mon, 26 Dec 2011 13:02:07 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755287Ab1LZMB5 convert rfc822-to-quoted-printable (ORCPT ); Mon, 26 Dec 2011 07:01:57 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:50135 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755276Ab1LZMBw (ORCPT ); Mon, 26 Dec 2011 07:01:52 -0500 Received: by mail-iy0-f174.google.com with SMTP id h11so18804004iae.19 for ; Mon, 26 Dec 2011 04:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=bmARTyBgxmk6pagvMxD//8xPPZRH4GeUtxTM2gQYIZk=; b=GfknEZF0/me0LjCUyRPcWTQcFGjQBpW3xwWkkJ/90gRBWZXzNdzDqw7kFe2iano5hy iCcjigfMJRHhQcMI04NSRu/oGEs4pr/v+OPG6SGDvNLxjhTp56CCeUnwOZhyXiTirqsB zuBPON24fbO84TaNKBa8HGjRNDgfW2w6ZzSAc= Received: by 10.42.164.71 with SMTP id f7mr25217298icy.49.1324900912728; Mon, 26 Dec 2011 04:01:52 -0800 (PST) Received: from tre ([115.74.49.128]) by mx.google.com with ESMTPS id py9sm37927722igc.2.2011.12.26.04.01.48 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Dec 2011 04:01:51 -0800 (PST) Received: by tre (sSMTP sendmail emulation); Mon, 26 Dec 2011 19:04:57 +0700 X-Mailer: git-send-email 1.7.8.36.g69ee2 In-Reply-To: <1324901080-23215-1-git-send-email-pclouds@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Revert the order of delta applying so that by the time a delta is applied, its base is either non-delta or already inflated. get_delta_base() is still recursive, but because base's data is always ready, the inner get_delta_base() call never has any chance to call itself again. Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy --- builtin/index-pack.c | 30 +++++++++++++++++++++--------- 1 files changed, 21 insertions(+), 9 deletions(-) diff --git a/builtin/index-pack.c b/builtin/index-pack.c index d311c05..e8801bb 100644 --- a/builtin/index-pack.c +++ b/builtin/index-pack.c @@ -519,10 +519,25 @@ static void *get_base_data(struct base_data *c) { if (!c->data) { struct object_entry *obj =3D c->obj; + struct base_data **delta =3D NULL; + int delta_nr =3D 0, delta_alloc =3D 0; =20 - if (is_delta_type(obj->type)) { - void *base =3D get_base_data(c->base); - void *raw =3D get_data_from_pack(obj); + for (; is_delta_type(c->obj->type); c =3D c->base) { + ALLOC_GROW(delta, delta_nr + 1, delta_alloc); + delta[delta_nr++] =3D c; + } + if (!delta_nr) { + c->data =3D get_data_from_pack(obj); + c->size =3D obj->size; + base_cache_used +=3D c->size; + prune_base_data(c); + } + for (; delta_nr > 0; delta_nr--) { + void *base, *raw; + c =3D delta[delta_nr - 1]; + obj =3D c->obj; + base =3D get_base_data(c->base); + raw =3D get_data_from_pack(obj); c->data =3D patch_delta( base, c->base->size, raw, obj->size, @@ -530,13 +545,10 @@ static void *get_base_data(struct base_data *c) free(raw); if (!c->data) bad_object(obj->idx.offset, "failed to apply delta"); - } else { - c->data =3D get_data_from_pack(obj); - c->size =3D obj->size; + base_cache_used +=3D c->size; + prune_base_data(c); } - - base_cache_used +=3D c->size; - prune_base_data(c); + free(delta); } return c->data; } --=20 1.7.8.36.g69ee2