git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Walton <bwalton@artsci.utoronto.ca>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Ben Walton <bwalton@artsci.utoronto.ca>
Subject: [PATCH] t0300-credentials: Word around a solaris /bin/sh bug
Date: Thu,  2 Feb 2012 14:32:15 -0500	[thread overview]
Message-ID: <1328211135-25217-1-git-send-email-bwalton@artsci.utoronto.ca> (raw)

Solaris' /bin/sh was making the IFS setting permanent instead of
temporary when using it to slurp in credentials in the generated
'dump' script of the 'setup helper scripts' test in t0300-credentials.

The stderr file that was being compared to expected-stderr contained the
following stray line from the credential helper run:

warning: invalid credential line: username foo

To avoid this bug, capture the original IFS and force it to be reset
after its use is no longer required.  For now, this is lighter weight
than altering which shell these scripts use as their shebang.

Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
---
 t/t0300-credentials.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
index 885af8f..1be3fe2 100755
--- a/t/t0300-credentials.sh
+++ b/t/t0300-credentials.sh
@@ -8,10 +8,12 @@ test_expect_success 'setup helper scripts' '
 	cat >dump <<-\EOF &&
 	whoami=`echo $0 | sed s/.*git-credential-//`
 	echo >&2 "$whoami: $*"
+	OIFS=$IFS
 	while IFS== read key value; do
 		echo >&2 "$whoami: $key=$value"
 		eval "$key=$value"
 	done
+	IFS=$OIFS
 	EOF
 
 	cat >git-credential-useless <<-\EOF &&
-- 
1.7.8.3

             reply	other threads:[~2012-02-02 19:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 19:32 Ben Walton [this message]
2012-02-02 19:44 ` [PATCH] t0300-credentials: Word around a solaris /bin/sh bug Frans Klaver
2012-02-02 19:48   ` Ben Walton
2012-02-02 20:02 ` Jeff King
2012-02-03  1:02   ` Junio C Hamano
2012-02-03 12:06     ` Jeff King
2012-02-03 13:45       ` Ben Walton
2012-02-03 20:32       ` Junio C Hamano
2012-02-03 21:26         ` Jeff King
2012-02-03 21:50           ` Junio C Hamano
2012-02-03 21:55             ` Jeff King
2012-02-03 22:00               ` Ben Walton
2012-02-03 22:45               ` Junio C Hamano
2012-02-03 23:27                 ` Jeff King
2012-02-04  6:27                 ` Jeff King
2012-02-04  6:29                   ` [PATCH 1/2] tests: add write_script helper function Jeff King
2012-02-04  6:30                   ` [PATCH 2/2] t0300: use write_script helper Jeff King
2012-02-04  6:58                     ` Junio C Hamano
2012-02-04  7:00                       ` Jeff King
2012-02-02 20:16 ` [PATCH] t0300-credentials: Word around a solaris /bin/sh bug Jonathan Nieder
2012-02-02 20:43   ` Matthieu Moy
2012-02-02 21:11     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328211135-25217-1-git-send-email-bwalton@artsci.utoronto.ca \
    --to=bwalton@artsci.utoronto.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).