From: Pete Wyckoff <pw@padd.com>
To: git@vger.kernel.org
Cc: "Laurent Charrière" <lcharriere@promptu.com>
Subject: [PATCH 0/2] git-p4: fix submit regression with --use-client-spec
Date: Sat, 25 Feb 2012 20:06:23 -0500 [thread overview]
Message-ID: <1330218385-22309-1-git-send-email-pw@padd.com> (raw)
This pair of patches fixes a regression that happened with ecb7cf9
(git-p4: rewrite view handling, 2012-01-02). There are two factors that
affect where files go in the client when submitting: the cilent spec,
and the depot path. When the depot path was not exactly the root of
the client, submit fails.
Fix this by always using the true client root. And also notice that
somebody has to tell the submit path that it should be looking at the
cilent spec. Save useClientSpec in a configuration variable if it
was specified as an option on the command line.
Junio: can you put this on maint to go out with the next 1.9.x?
Pete Wyckoff (2):
git-p4: set useClientSpec variable on initial clone
git-p4: fix submit regression with clientSpec and subdir clone
Documentation/git-p4.txt | 10 ++-
contrib/fast-import/git-p4 | 97 ++++++++++++++++---------
t/t9809-git-p4-client-view.sh | 159 ++++++++++++++++++++++++++++++++++++++---
3 files changed, 219 insertions(+), 47 deletions(-)
--
1.7.9.219.g1d56c.dirty
next reply other threads:[~2012-02-26 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 1:06 Pete Wyckoff [this message]
2012-02-26 1:06 ` [PATCH 1/2] git-p4: set useClientSpec variable on initial clone Pete Wyckoff
2012-02-26 1:06 ` [PATCH 2/2] git-p4: fix submit regression with clientSpec and subdir clone Pete Wyckoff
2012-02-27 0:18 ` [PATCH 0/2] git-p4: fix submit regression with --use-client-spec Junio C Hamano
2012-02-27 0:25 ` Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330218385-22309-1-git-send-email-pw@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=lcharriere@promptu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).