* [PATCH 0/2] Trivial cleanups in the post-receive-email script
@ 2012-02-27 18:34 mhagger
2012-02-27 18:34 ` [PATCH 1/2] post-receive-email: remove unused variable mhagger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: mhagger @ 2012-02-27 18:34 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Kevin P. Fleming, Andy Parkins, Michael Haggerty
From: Michael Haggerty <mhagger@alum.mit.edu>
Should be self-explanatory.
Michael Haggerty (2):
post-receive-email: remove unused variable
post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly
contrib/hooks/post-receive-email | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
--
1.7.9
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] post-receive-email: remove unused variable
2012-02-27 18:34 [PATCH 0/2] Trivial cleanups in the post-receive-email script mhagger
@ 2012-02-27 18:34 ` mhagger
2012-02-27 18:34 ` [PATCH 2/2] post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly mhagger
2012-02-27 19:01 ` [PATCH 0/2] Trivial cleanups in the post-receive-email script Junio C Hamano
2 siblings, 0 replies; 4+ messages in thread
From: mhagger @ 2012-02-27 18:34 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Kevin P. Fleming, Andy Parkins, Michael Haggerty
From: Michael Haggerty <mhagger@alum.mit.edu>
prep_for_email neither is passed a fourth argument nor uses it.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
contrib/hooks/post-receive-email | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index ba077c1..ac2e0ed 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -85,7 +85,6 @@ prep_for_email()
oldrev=$(git rev-parse $1)
newrev=$(git rev-parse $2)
refname="$3"
- maxlines=$4
# --- Interpret
# 0000->1234 (create)
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly
2012-02-27 18:34 [PATCH 0/2] Trivial cleanups in the post-receive-email script mhagger
2012-02-27 18:34 ` [PATCH 1/2] post-receive-email: remove unused variable mhagger
@ 2012-02-27 18:34 ` mhagger
2012-02-27 19:01 ` [PATCH 0/2] Trivial cleanups in the post-receive-email script Junio C Hamano
2 siblings, 0 replies; 4+ messages in thread
From: mhagger @ 2012-02-27 18:34 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Kevin P. Fleming, Andy Parkins, Michael Haggerty
From: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
contrib/hooks/post-receive-email | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index ac2e0ed..01af9df 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -460,7 +460,7 @@ generate_delete_branch_email()
{
echo " was $oldrev"
echo ""
- echo $LOGEND
+ echo $LOGBEGIN
git show -s --pretty=oneline $oldrev
echo $LOGEND
}
@@ -560,7 +560,7 @@ generate_delete_atag_email()
{
echo " was $oldrev"
echo ""
- echo $LOGEND
+ echo $LOGBEGIN
git show -s --pretty=oneline $oldrev
echo $LOGEND
}
@@ -625,7 +625,7 @@ generate_delete_general_email()
{
echo " was $oldrev"
echo ""
- echo $LOGEND
+ echo $LOGBEGIN
git show -s --pretty=oneline $oldrev
echo $LOGEND
}
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] Trivial cleanups in the post-receive-email script
2012-02-27 18:34 [PATCH 0/2] Trivial cleanups in the post-receive-email script mhagger
2012-02-27 18:34 ` [PATCH 1/2] post-receive-email: remove unused variable mhagger
2012-02-27 18:34 ` [PATCH 2/2] post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly mhagger
@ 2012-02-27 19:01 ` Junio C Hamano
2 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2012-02-27 19:01 UTC (permalink / raw)
To: mhagger; +Cc: git, Kevin P. Fleming, Andy Parkins
Shows that nobody uses these sample script.
Will apply. I wish all the patches were this easy ;-).
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-27 19:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-27 18:34 [PATCH 0/2] Trivial cleanups in the post-receive-email script mhagger
2012-02-27 18:34 ` [PATCH 1/2] post-receive-email: remove unused variable mhagger
2012-02-27 18:34 ` [PATCH 2/2] post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly mhagger
2012-02-27 19:01 ` [PATCH 0/2] Trivial cleanups in the post-receive-email script Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).