From: Tim Henigan <tim.henigan@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Tim Henigan <tim.henigan@gmail.com>
Subject: [PATCH 2/5 v2] contrib/diffall: create tmp dirs without mktemp
Date: Wed, 14 Mar 2012 12:38:03 -0400 [thread overview]
Message-ID: <1331743086-32304-3-git-send-email-tim.henigan@gmail.com> (raw)
In-Reply-To: <1331743086-32304-1-git-send-email-tim.henigan@gmail.com>
mktemp is not available on all platforms. Instead of littering the code
with a work-around, this commit replaces mktemp with a one-line Perl
script.
Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
---
v2 did not affect this patch.
contrib/diffall/git-diffall | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/contrib/diffall/git-diffall b/contrib/diffall/git-diffall
index d706a6d..443f646 100755
--- a/contrib/diffall/git-diffall
+++ b/contrib/diffall/git-diffall
@@ -45,13 +45,10 @@ cd "$cdup" || {
exit 1
}
-# mktemp is not available on all platforms (missing from msysgit)
-# Use a hard-coded tmp dir if it is not available
-tmp="$(mktemp -d -t tmp.XXXXXX 2>/dev/null)" || {
- tmp=/tmp/git-diffall-tmp.$$
- mkdir "$tmp" || exit 1
-}
-
+# set up temp dir
+tmp=$(perl -e 'use File::Temp qw(tempdir);
+ $t=tempdir("/tmp/git-diffall.XXXXX") or exit(1);
+ print $t') || exit 1
trap 'rm -rf "$tmp" 2>/dev/null' EXIT
left=
--
1.7.10.rc0
next prev parent reply other threads:[~2012-03-14 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 16:38 [PATCH 0/5 v2] contrib/diffall: improvements Tim Henigan
2012-03-14 16:38 ` [PATCH 1/5 v2] contrib/diffall: comment actual reason for 'cdup' Tim Henigan
2012-03-14 16:38 ` Tim Henigan [this message]
2012-03-14 16:38 ` [PATCH 3/5 v2] contrib/diffall: eliminate use of tar Tim Henigan
2012-03-14 16:38 ` [PATCH 4/5 v2] contrib/diffall: eliminate duplicate while loops Tim Henigan
2012-03-14 16:38 ` [PATCH 5/5 v2] contrib/diffall: fix cleanup trap on Windows Tim Henigan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331743086-32304-3-git-send-email-tim.henigan@gmail.com \
--to=tim.henigan@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).