From: Tim Henigan <tim.henigan@gmail.com>
To: gitster@pobox.com, davvid@gmail.com, git@vger.kernel.org
Cc: Tim Henigan <tim.henigan@gmail.com>
Subject: [PATCH 8/9] difftool: teach dir-diff to copy modified files back to working tree
Date: Fri, 16 Mar 2012 21:59:54 -0400 [thread overview]
Message-ID: <1331949594-15238-1-git-send-email-tim.henigan@gmail.com> (raw)
If the user runs a diff when there are modified files in the working copy,
they expect to be able to be edit the files in the diff viewer and save
the changes. When using difftool in file mode (i.e. diffing one file at
a time), this works as expected. However, when using difftool in directory
diff mode, the changes are not saved.
This commit teaches the directory diff mode to copy changes from the diff
viewer back to the working copy.
Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
---
git-difftool.perl | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/git-difftool.perl b/git-difftool.perl
index 0262c7a..ebffd1e 100755
--- a/git-difftool.perl
+++ b/git-difftool.perl
@@ -22,6 +22,8 @@ use File::Temp qw(tempdir);
use Getopt::Long qw(:config pass_through);
use Git;
+my @working_tree;
+
sub usage
{
my $exitcode = shift;
@@ -54,7 +56,6 @@ sub setup_dir_diff
my $null_sha1 = 0 x 40;
my $lindex = "";
my $rindex = "";
- my @working_tree;
my %submodule;
my @rawdiff = split('\0', $diffrtn);
@@ -176,9 +177,16 @@ if (defined($dirdiff)) {
$ENV{GIT_DIFFTOOL_DIRDIFF} = 'true';
system("git difftool--helper $a $b");
}
- # TODO: if the diff including working copy files and those
+
+ # If the diff including working copy files and those
# files were modified during the diff, then the changes
# should be copied back to the working tree
+ my $repo = Git->repository();
+ my $workdir = $repo->wc_path();
+ for (@working_tree) {
+ copy("$b/$_", "$workdir/$_") or die $!;
+ chmod(stat("$b/$_")->mode, "$workdir/$_") or die $!;
+ }
} else {
if (defined($prompt)) {
$ENV{GIT_DIFFTOOL_PROMPT} = 'true';
--
1.7.9.1.290.gbd444
reply other threads:[~2012-03-17 2:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331949594-15238-1-git-send-email-tim.henigan@gmail.com \
--to=tim.henigan@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).