From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: Paul Mackerras <paulus@samba.org>
Cc: <git@vger.kernel.org>, Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: gitk: Failure of new tabbed preferences dialog
Date: Sun, 1 Apr 2012 23:00:50 +0100 [thread overview]
Message-ID: <1333317652-1464-1-git-send-email-patthoyts@users.sourceforge.net> (raw)
In-Reply-To: <4F749C71.7050201@ramsay1.demon.co.uk>
> I just tried the new gitk (master @fae9d76) and, since I don't have
> themed widgets, the preferences menu item uses the emulated tabbed
> dialog code, which fails like so:
>
> can't read "col": no such variable
>
The issue here is that the incr command has changed between tcl 8.4
and 8.5 and in more recent versions automatically creates the named
variable if it did not exist. The fix you suggest is correct. I've
also included another that I realised had been applied to msysGit and
was not posted upstream.
Pat Thoyts.
next prev parent reply other threads:[~2012-04-01 23:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 17:31 gitk: Failure of new tabbed preferences dialog Ramsay Jones
2012-04-01 22:00 ` Pat Thoyts [this message]
2012-04-01 22:00 ` [PATCH 1/2] gitk: fix tabbed preferences construction when using tcl 8.4 Pat Thoyts
2012-04-01 22:00 ` [PATCH 2/2] gitk: fix setting font display with new tabbed dialog layout Pat Thoyts
2012-04-02 16:19 ` gitk: Failure of new tabbed preferences dialog Junio C Hamano
2012-04-02 22:03 ` Junio C Hamano
2012-04-03 12:19 ` Paul Mackerras
2012-04-03 16:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333317652-1464-1-git-send-email-patthoyts@users.sourceforge.net \
--to=patthoyts@users.sourceforge.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).