git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: git@vger.kernel.org
Cc: Luke Diamand <luke@diamand.org>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/3] git-p4: move to toplevel
Date: Sun,  8 Apr 2012 20:17:59 -0400	[thread overview]
Message-ID: <1333930682-31670-1-git-send-email-pw@padd.com> (raw)

Users install git-p4 currently by copying the git-p4 script from
contrib/fast-import into a local or personal bin directory.  If
it is part of the install, the command will be available
automatically.  Also, distributions may be more likely to pick it
up either as part of a core git package, or as a separate add-on.


This series appeared as an RFC two months ago:

    http://thread.gmane.org/gmane.comp.version-control.git/190584

The git-p4 code is in a single python script down in
contrib/fast-import now.  I'd like to move it up to the top-level
source directory of git to make it easier to build and
distribute.  Git-p4 already takes advantage of the git
infrastructure for documentation and testing, as well as the
community support (Junio, many reviewers).

The only observation from the RFC series was that git-p4 is
useful only in the non-open-source world.  While you can download
p4 for testing, a production environment is not free.  No one
particularly complained about that though.

Changes since then:

    - Fix bug in name in Documentation/git-p4.txt.

    - Add to command-list.txt.

    - Adapt to other git-p4 changes.

    - I tested git-p4 on msysgit and cygwin, making sure it passes
      all the tests.  Getting installers for git-p4 in those
      environments should be possible soon.  Fixes for windows
      will appear as a separate series.


Developer note:  Like all scripts in git, the source file has
an extension, git-p4.py, which is built with "make" to git-p4.
Be sure to edit the source file, and to build before running tests.

Installer note: git-p4 uses the existing python dependencies in
the Makefile.  Be sure _not_ to set NO_PYTHON; build and install
as usual.  If your python (2.6 or 2.7) is not in /usr/bin/python,
set PYTHON_PATH accordingly.  Git-p4 does not require the
git_remote_helpers that are also installed.


It would be good to have this in next early in the 1.7.11 series
so we can send the rest of the patches on top of this.  It
conflicts fairly heavily with other changes, obviously.  I think
there are 4-5 other outstanding git-p4 series.

		-- Pete

Pete Wyckoff (3):
  git-p4: move to toplevel
  git p4: update name in script
  git p4: use "git p4" directly in tests

 .gitignore                              |    1 +
 Documentation/git-p4.txt                |   19 +++----
 INSTALL                                 |    3 ++
 Makefile                                |    1 +
 command-list.txt                        |    1 +
 contrib/fast-import/git-p4.README       |   13 +++++
 contrib/fast-import/git-p4.bat          |    1 -
 contrib/fast-import/git-p4 => git-p4.py |   14 ++---
 t/lib-git-p4.sh                         |    8 ++-
 t/t9800-git-p4-basic.sh                 |   84 ++++++++++++++---------------
 t/t9801-git-p4-branch.sh                |   32 +++++------
 t/t9802-git-p4-filetype.sh              |   10 ++--
 t/t9803-git-p4-shell-metachars.sh       |   12 ++---
 t/t9804-git-p4-label.sh                 |    6 +--
 t/t9805-git-p4-skip-submit-edit.sh      |   22 ++++----
 t/t9806-git-p4-options.sh               |   28 +++++-----
 t/t9807-git-p4-submit.sh                |   22 ++++----
 t/t9808-git-p4-chdir.sh                 |    6 +--
 t/t9809-git-p4-client-view.sh           |   88 +++++++++++++++----------------
 t/t9810-git-p4-rcs.sh                   |   48 ++++++++---------
 20 files changed, 214 insertions(+), 205 deletions(-)
 create mode 100644 contrib/fast-import/git-p4.README
 delete mode 100644 contrib/fast-import/git-p4.bat
 rename contrib/fast-import/git-p4 => git-p4.py (99%)

-- 
1.7.10.4.gb369

             reply	other threads:[~2012-04-09  0:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09  0:17 Pete Wyckoff [this message]
2012-04-09  0:18 ` [PATCH 1/3] git-p4: move to toplevel Pete Wyckoff
2012-04-09  0:18 ` [PATCH 2/3] git p4: update name in script Pete Wyckoff
2012-04-09  0:18 ` [PATCH 3/3] git p4: use "git p4" directly in tests Pete Wyckoff
2012-04-09 18:32 ` [PATCH 0/3] git-p4: move to toplevel Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333930682-31670-1-git-send-email-pw@padd.com \
    --to=pw@padd.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).