git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: Pete Wyckoff <pw@padd.com>, Junio C Hamano <gitster@pobox.com>,
	Vitor Antunes <vitor.hda@gmail.com>,
	Luke Diamand <luke@diamand.org>
Subject: [PATCHv3 0/4] git p4: label import/export
Date: Tue, 24 Apr 2012 09:08:12 +0100	[thread overview]
Message-ID: <1335254897-15242-1-git-send-email-luke@diamand.org> (raw)

This is a reworked version of my earlier patches for adding
improved label import/export support to "git p4", and
incorporates comments from Pete Wyckoff and Junio:

Comments from Pete:

* The verbose flag has been hoisted to the Command class.
* Uses the existing functions to fish out p4 changelist numbers.
* Config options renamed to be self-consistent, and regexp
  now includes lower-case characters.

I have left the tests in t9811 where they are, so that the t9804
script can be used solely for "--detect-labels".

Comments from Junio:

* P4EDITOR is set to the always-true value in the test harness
* Treat an empty P4EDITOR the same as an unset P4EDITOR.

There was a discussion about having "git p4" fall back to a default in
the same way that "p4" does, but this would change the existing behavior
(use git var GIT_EDITOR) and confuse users.

This patch series was reworked against ld/git-p4-tags-and-labels and
also has a very small documentation fix.

Luke Diamand (5):
  git p4: Fixing script editor checks
  git p4: Squash P4EDITOR in test harness
  git p4: Ignore P4EDITOR if it is empty
  git p4: import/export of labels to/from p4
  git p4: move verbose to base class

 Documentation/git-p4.txt       |   54 ++++++--
 git-p4.py                      |  289 ++++++++++++++++++++++++++++++++--------
 t/lib-git-p4.sh                |    1 +
 t/t9800-git-p4-basic.sh        |    4 +-
 t/t9811-git-p4-label-import.sh |  202 ++++++++++++++++++++++++++++
 5 files changed, 482 insertions(+), 68 deletions(-)
 create mode 100755 t/t9811-git-p4-label-import.sh

-- 
1.7.10.381.gb484f

             reply	other threads:[~2012-04-24  8:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  8:08 Luke Diamand [this message]
2012-04-24  8:08 ` [PATCHv3 1/5] git p4: Fixing script editor checks Luke Diamand
2012-04-24  8:08 ` [PATCHv3 2/5] git p4: Squash P4EDITOR in test harness Luke Diamand
2012-04-24  8:08 ` [PATCHv3 3/5] git p4: Ignore P4EDITOR if it is empty Luke Diamand
2012-04-24  8:08 ` [PATCHv3 4/5] git p4: import/export of labels to/from p4 Luke Diamand
2012-04-24  8:08 ` [PATCHv3 5/5] git p4: move verbose to base class Luke Diamand
2012-04-25 22:22 ` [PATCHv3 0/4] git p4: label import/export Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335254897-15242-1-git-send-email-luke@diamand.org \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pw@padd.com \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).