git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: Pete Wyckoff <pw@padd.com>, Junio C Hamano <gitster@pobox.com>,
	Vitor Antunes <vitor.hda@gmail.com>,
	Luke Diamand <luke@diamand.org>
Subject: [PATCHv3 2/5] git p4: Squash P4EDITOR in test harness
Date: Tue, 24 Apr 2012 09:08:14 +0100	[thread overview]
Message-ID: <1335254897-15242-3-git-send-email-luke@diamand.org> (raw)
In-Reply-To: <1335254897-15242-1-git-send-email-luke@diamand.org>

If P4EDITOR is set in the environment, test behavior could be
unpredictable. Set it explicitly.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/lib-git-p4.sh |    1 +
 1 file changed, 1 insertion(+)

diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index b90986c..121e380 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib-git-p4.sh
@@ -24,6 +24,7 @@ P4DPORT=$((10669 + ($testid - $git_p4_test_start)))
 
 export P4PORT=localhost:$P4DPORT
 export P4CLIENT=client
+export P4EDITOR=:
 
 db="$TRASH_DIRECTORY/db"
 cli="$TRASH_DIRECTORY/cli"
-- 
1.7.10.381.gb484f

  parent reply	other threads:[~2012-04-24  8:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  8:08 [PATCHv3 0/4] git p4: label import/export Luke Diamand
2012-04-24  8:08 ` [PATCHv3 1/5] git p4: Fixing script editor checks Luke Diamand
2012-04-24  8:08 ` Luke Diamand [this message]
2012-04-24  8:08 ` [PATCHv3 3/5] git p4: Ignore P4EDITOR if it is empty Luke Diamand
2012-04-24  8:08 ` [PATCHv3 4/5] git p4: import/export of labels to/from p4 Luke Diamand
2012-04-24  8:08 ` [PATCHv3 5/5] git p4: move verbose to base class Luke Diamand
2012-04-25 22:22 ` [PATCHv3 0/4] git p4: label import/export Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335254897-15242-3-git-send-email-luke@diamand.org \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pw@padd.com \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).