From: Pete Wyckoff <pw@padd.com>
To: git@vger.kernel.org
Subject: [PATCH 0/2] minor error message newline purge
Date: Sun, 29 Apr 2012 20:28:44 -0400 [thread overview]
Message-ID: <1335745726-2583-1-git-send-email-pw@padd.com> (raw)
Some error messages show up with an extra blank line, like this
one:
$ git commit -m foo
unable to create temporary sha1 filename : Too many open files
error: Error building trees
$
Most of the callers of error() and similar functions in usage.c
don't add a newline, but a few do, causing odd output like the
above.
No tests for these; they're hopefully trivial. One of the edited
messages was marked for translation. I'm not sure if changing it
requires any work in po/.
Pete Wyckoff (2):
remove superfluous newlines in error messages
remove blank filename in error message
builtin/branch.c | 2 +-
builtin/merge-file.c | 4 ++--
builtin/unpack-objects.c | 2 +-
compat/win32mmap.c | 2 +-
contrib/examples/builtin-fetch--tool.c | 4 ++--
fsck.c | 2 +-
http-push.c | 4 ++--
http.c | 2 +-
imap-send.c | 2 +-
ll-merge.c | 2 +-
object.c | 6 +++---
sha1_file.c | 6 +++---
transport-helper.c | 4 ++--
unpack-trees.c | 2 +-
vcs-svn/svndump.c | 4 ++--
15 files changed, 24 insertions(+), 24 deletions(-)
--
1.7.10.572.ged86f
next reply other threads:[~2012-04-30 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 0:28 Pete Wyckoff [this message]
2012-04-30 0:28 ` [PATCH 1/2] remove superfluous newlines in error messages Pete Wyckoff
2012-04-30 0:28 ` [PATCH 2/2] remove blank filename in error message Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335745726-2583-1-git-send-email-pw@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).