From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH] sha1_name: support sha1^{note} to return note sha-1
Date: Tue, 8 May 2012 20:14:30 +0700 [thread overview]
Message-ID: <1336482870-30842-1-git-send-email-pclouds@gmail.com> (raw)
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
It may be useful for scripting, and looks nice. Though may be not
worth adding if there are no actual users.
Documentation/revisions.txt | 1 +
sha1_name.c | 15 ++++++++++++++-
2 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt
index 1725661..5a671fe 100644
--- a/Documentation/revisions.txt
+++ b/Documentation/revisions.txt
@@ -114,6 +114,7 @@ the '$GIT_DIR/refs' directory or from the '$GIT_DIR/packed-refs' file.
object of that type is found or the object cannot be
dereferenced anymore (in which case, barf). '<rev>{caret}0'
is a short-hand for '<rev>{caret}\{commit\}'.
+ A special type "note" can be used to return the note object.
'<rev>{caret}\{\}', e.g. 'v0.99.8{caret}\{\}'::
A suffix '{caret}' followed by an empty brace pair
diff --git a/sha1_name.c b/sha1_name.c
index c633113..02d28df 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -6,6 +6,7 @@
#include "tree-walk.h"
#include "refs.h"
#include "remote.h"
+#include "notes.h"
static int get_sha1_oneline(const char *, unsigned char *, struct commit_list *);
@@ -473,7 +474,19 @@ static int peel_onion(const char *name, int len, unsigned char *sha1)
expected_type = OBJ_NONE;
else if (sp[0] == '/')
expected_type = OBJ_COMMIT;
- else
+ else if (!strncmp("note}", sp, 5)) {
+ const unsigned char *note;
+ struct notes_tree t;
+ if (get_sha1_1(name, sp - name - 2, outer))
+ return -1;
+ memset(&t, 0, sizeof(t));
+ init_notes(&t, NULL, NULL, 0);
+ note = get_note(&t, outer);
+ if (note)
+ hashcpy(sha1, note);
+ free_notes(&t);
+ return note ? 0 : -1;
+ } else
return -1;
if (get_sha1_1(name, sp - name - 2, outer))
--
1.7.8.36.g69ee2
next reply other threads:[~2012-05-08 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 13:14 Nguyễn Thái Ngọc Duy [this message]
2012-05-08 16:11 ` [PATCH] sha1_name: support sha1^{note} to return note sha-1 Jeff King
2012-05-09 8:25 ` Nguyen Thai Ngoc Duy
2012-05-09 14:09 ` Johan Herland
2012-05-09 17:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336482870-30842-1-git-send-email-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).