From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v2 3/9] apply: split load_preimage() helper function out
Date: Thu, 10 May 2012 15:32:47 -0700 [thread overview]
Message-ID: <1336689173-15822-4-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1336689173-15822-1-git-send-email-gitster@pobox.com>
The function apply_data() gets a patch for a single path, reads the
preimage in core, and applies the change represented in the patch.
Separate out the first part that reads the preimage into a separate
helper function load_preimage().
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin/apply.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index ca330e3..2a31023 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -3028,10 +3028,10 @@ static void prepare_fn_table(struct patch *patch)
}
}
-static int apply_data(struct patch *patch, struct stat *st, struct cache_entry *ce)
+static int load_preimage(struct image *image,
+ struct patch *patch, struct stat *st, struct cache_entry *ce)
{
struct strbuf buf = STRBUF_INIT;
- struct image image;
size_t len;
char *img;
struct patch *tpatch;
@@ -3068,7 +3068,16 @@ static int apply_data(struct patch *patch, struct stat *st, struct cache_entry *
}
img = strbuf_detach(&buf, &len);
- prepare_image(&image, img, len, !patch->is_binary);
+ prepare_image(image, img, len, !patch->is_binary);
+ return 0;
+}
+
+static int apply_data(struct patch *patch, struct stat *st, struct cache_entry *ce)
+{
+ struct image image;
+
+ if (load_preimage(&image, patch, st, ce) < 0)
+ return -1;
if (apply_fragments(&image, patch) < 0)
return -1; /* note with --reject this succeeds. */
--
1.7.10.1.574.g840b38f
next prev parent reply other threads:[~2012-05-10 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 22:32 [PATCH v2 0/9] "git apply --3way" Junio C Hamano
2012-05-10 22:32 ` [PATCH v2 1/9] apply: clear_image() clears things a bit more Junio C Hamano
2012-05-10 22:32 ` [PATCH v2 2/9] apply: refactor read_file_or_gitlink() Junio C Hamano
2012-05-10 22:32 ` Junio C Hamano [this message]
2012-05-10 22:32 ` [PATCH v2 4/9] apply: accept -3/--3way command line option Junio C Hamano
2012-05-10 22:32 ` [PATCH v2 5/9] apply: fall back on three-way merge Junio C Hamano
2012-05-10 22:32 ` [PATCH v2 6/9] apply: plug the three-way merge logic in Junio C Hamano
2012-05-10 22:32 ` [PATCH v2 7/9] apply: register conflicted stages to the index Junio C Hamano
2012-05-10 22:32 ` [PATCH v2 8/9] apply: allow rerere() upon --3way results Junio C Hamano
2012-05-10 22:32 ` [PATCH v2 9/9] apply: document --3way option Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336689173-15822-4-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).