git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Pete Wyckoff <pw@padd.com>,
	Luke Diamand <luke@diamand.org>
Subject: [PATCHv1 2/3] git p4: fix bug when verbose enabled with tag export
Date: Fri, 11 May 2012 07:25:17 +0100	[thread overview]
Message-ID: <1336717518-4214-3-git-send-email-luke@diamand.org> (raw)
In-Reply-To: <1336717518-4214-1-git-send-email-luke@diamand.org>

Wrong variable name used when verbose enabled, causes failure.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-p4.py b/git-p4.py
index 565cfbc..8f0169a 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1302,7 +1302,7 @@ class P4Submit(Command, P4UserMap):
 
             if not m.match(name):
                 if verbose:
-                    print "tag %s does not match regexp %s" % (name, validTagRegexp)
+                    print "tag %s does not match regexp %s" % (name, validLabelRegexp)
                 continue
 
             # Get the p4 commit this corresponds to
-- 
1.7.10.282.g2120.dirty

  parent reply	other threads:[~2012-05-11  6:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  6:25 [PATCHv1 0/3] git p4: tag import/export bug fixes Luke Diamand
2012-05-11  6:25 ` [PATCHv1 1/3] git p4: add test for tag import/export enabled via config Luke Diamand
2012-05-11  6:25 ` Luke Diamand [this message]
2012-05-11  6:25 ` [PATCHv1 3/3] git p4: fix bug when enabling tag import/export via config variables Luke Diamand
2012-05-11 10:21 ` [PATCHv1 0/3] git p4: tag import/export bug fixes Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336717518-4214-3-git-send-email-luke@diamand.org \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pw@padd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).