From: mhagger@alum.mit.edu
To: Junio C Hamano <gitster@pobox.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH v2 0/4] Fix some constness errors in fetch-pack
Date: Mon, 21 May 2012 09:59:55 +0200 [thread overview]
Message-ID: <1337587199-21099-1-git-send-email-mhagger@alum.mit.edu> (raw)
From: Michael Haggerty <mhagger@alum.mit.edu>
Fix some constness errors that I noticed while reading the code in
builtin/fetch-pack.c.
This version differs from v1 as follows:
* cmd_fetch_pack() is not made to free the memory that it allocates.
* The second patch is broken into separate pieces to make each piece
more readable.
Michael Haggerty (4):
cmd_fetch_pack(): declare dest to be const
cmd_fetch_pack(): handle non-option arguments outside of the loop
cmd_fetch_pack(): combine the loop termination conditions
cmd_fetch_pack(): respect constness of argv parameter
builtin/fetch-pack.c | 145 ++++++++++++++++++++++++--------------------------
1 file changed, 71 insertions(+), 74 deletions(-)
--
1.7.10
next reply other threads:[~2012-05-21 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 7:59 mhagger [this message]
2012-05-21 7:59 ` [PATCH v2 1/4] cmd_fetch_pack(): declare dest to be const mhagger
2012-05-21 7:59 ` [PATCH v2 2/4] cmd_fetch_pack(): handle non-option arguments outside of the loop mhagger
2012-05-21 7:59 ` [PATCH v2 3/4] cmd_fetch_pack(): combine the loop termination conditions mhagger
2012-05-21 7:59 ` [PATCH v2 4/4] cmd_fetch_pack(): respect constness of argv parameter mhagger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337587199-21099-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).