* [PATCH] git-web--browse: Fix open HTML help pages from iTerm
@ 2012-05-23 4:10 Steffen Prohaska
0 siblings, 0 replies; 4+ messages in thread
From: Steffen Prohaska @ 2012-05-23 4:10 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Steffen Prohaska
iTerm is an alternative to the default terminal emulation program on Mac
OS X. git-web--browse wasn't aware of iTerm and failed to open HTML help
pages when used in a shell session running in iTerm, reporting "No known
browser available." Now it works as expected and opens HTML pages.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
git-web--browse.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-web--browse.sh b/git-web--browse.sh
index 1e82726..95ecf65 100755
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -120,7 +120,8 @@ if test -z "$browser" ; then
fi
# SECURITYSESSIONID indicates an OS X GUI login session
if test -n "$SECURITYSESSIONID" \
- -o "$TERM_PROGRAM" = "Apple_Terminal" ; then
+ -o "$TERM_PROGRAM" = "Apple_Terminal" \
+ -o "$TERM_PROGRAM" = "iTerm.app" ; then
browser_candidates="open $browser_candidates"
fi
# /bin/start indicates MinGW
--
1.7.10.2.554.g7af14ee
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] git-web--browse: Fix open HTML help pages from iTerm
@ 2012-09-25 18:16 Steffen Prohaska
2012-09-27 19:11 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Steffen Prohaska @ 2012-09-25 18:16 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Steffen Prohaska
iTerm is an alternative to the default terminal emulation program on Mac
OS X. git-web--browse wasn't aware of iTerm and failed to open HTML
help pages when used in a shell session running in iTerm, reporting "No
known browser available." Now it works as expected.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
git-web--browse.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/git-web--browse.sh b/git-web--browse.sh
index 1e82726..95ecf65 100755
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -120,7 +120,8 @@ if test -z "$browser" ; then
fi
# SECURITYSESSIONID indicates an OS X GUI login session
if test -n "$SECURITYSESSIONID" \
- -o "$TERM_PROGRAM" = "Apple_Terminal" ; then
+ -o "$TERM_PROGRAM" = "Apple_Terminal" \
+ -o "$TERM_PROGRAM" = "iTerm.app" ; then
browser_candidates="open $browser_candidates"
fi
# /bin/start indicates MinGW
--
1.7.12.1.403.g14e83b4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] git-web--browse: Fix open HTML help pages from iTerm
2012-09-25 18:16 Steffen Prohaska
@ 2012-09-27 19:11 ` Junio C Hamano
2012-09-27 19:31 ` Steffen Prohaska
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2012-09-27 19:11 UTC (permalink / raw)
To: Steffen Prohaska; +Cc: git
Steffen Prohaska <prohaska@zib.de> writes:
> iTerm is an alternative to the default terminal emulation program on Mac
> OS X. git-web--browse wasn't aware of iTerm and failed to open HTML
> help pages when used in a shell session running in iTerm, reporting "No
> known browser available." Now it works as expected.
>
> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
> ---
> git-web--browse.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/git-web--browse.sh b/git-web--browse.sh
> index 1e82726..95ecf65 100755
> --- a/git-web--browse.sh
> +++ b/git-web--browse.sh
> @@ -120,7 +120,8 @@ if test -z "$browser" ; then
> fi
> # SECURITYSESSIONID indicates an OS X GUI login session
> if test -n "$SECURITYSESSIONID" \
> - -o "$TERM_PROGRAM" = "Apple_Terminal" ; then
> + -o "$TERM_PROGRAM" = "Apple_Terminal" \
> + -o "$TERM_PROGRAM" = "iTerm.app" ; then
> browser_candidates="open $browser_candidates"
> fi
I do not have anything against iTerm, but could we have a solution
that does not force us to keep adding 47 different terminal program
names to the list over the longer term (no pun intended)? For
example, "If on OS-X (which by the way does not seem to be checked
with the current logic) and environment TERM_PROGRAM is set to any
value", or something.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-web--browse: Fix open HTML help pages from iTerm
2012-09-27 19:11 ` Junio C Hamano
@ 2012-09-27 19:31 ` Steffen Prohaska
0 siblings, 0 replies; 4+ messages in thread
From: Steffen Prohaska @ 2012-09-27 19:31 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Sep 27, 2012, at 9:11 PM, Junio C Hamano wrote:
> Steffen Prohaska <prohaska@zib.de> writes:
>
>> iTerm is an alternative to the default terminal emulation program on Mac
>> OS X. git-web--browse wasn't aware of iTerm and failed to open HTML
>> help pages when used in a shell session running in iTerm, reporting "No
>> known browser available." Now it works as expected.
>>
>> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
>> ---
>> git-web--browse.sh | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/git-web--browse.sh b/git-web--browse.sh
>> index 1e82726..95ecf65 100755
>> --- a/git-web--browse.sh
>> +++ b/git-web--browse.sh
>> @@ -120,7 +120,8 @@ if test -z "$browser" ; then
>> fi
>> # SECURITYSESSIONID indicates an OS X GUI login session
>> if test -n "$SECURITYSESSIONID" \
>> - -o "$TERM_PROGRAM" = "Apple_Terminal" ; then
>> + -o "$TERM_PROGRAM" = "Apple_Terminal" \
>> + -o "$TERM_PROGRAM" = "iTerm.app" ; then
>> browser_candidates="open $browser_candidates"
>> fi
>
> I do not have anything against iTerm, but could we have a solution
> that does not force us to keep adding 47 different terminal program
> names to the list over the longer term (no pun intended)? For
> example, "If on OS-X (which by the way does not seem to be checked
> with the current logic) and environment TERM_PROGRAM is set to any
> value", or something.
I googled a bit and it seems that TERM_PROGRAM is specific to OS X.
So simply testing whether TERM_PROGRAM is set to any value (without
additional check for OS X) might be good enough.
I am wondering whether anyone knows if TERM_PROGRAM is used on other
operating systems besides OS X.
Steffen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-27 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 4:10 [PATCH] git-web--browse: Fix open HTML help pages from iTerm Steffen Prohaska
-- strict thread matches above, loose matches on Subject: below --
2012-09-25 18:16 Steffen Prohaska
2012-09-27 19:11 ` Junio C Hamano
2012-09-27 19:31 ` Steffen Prohaska
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).