git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Jens.Lehmann@web.de,
	Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v5 0/2] series: submodule: fix handling of relative superproject origin URLs
Date: Thu, 24 May 2012 13:37:35 +1000	[thread overview]
Message-ID: <1337830657-16400-1-git-send-email-jon.seymour@gmail.com> (raw)

This series ensures that git submodule handles relative superproject origin URLs correctly.

Current behaviour:

* does not guarantee that the submodule.{name}.url property of the superproject is 
always confgured with a valid path to the submodule's origin repo that is 
relative to the working tree of the superproject.
* does not guarantee that the remote.origin.url property of the submodule is
always configured with a valid path to the submodule's origin repo that is 
relative to the working tree of the submodule
* errors out (origin URL = foo) even though this is not strictly necessary.

These changes:

* guarantee that the configured paths are always valid relative paths
from the working tree of the repo containing to the configuration to the
origin repo of the described submodule.

Jon Seymour (2):
  submodule: document failures handling relative superproject origin
    URLs
  submodule: fix handling of relative superproject origin URLs

 git-submodule.sh           | 57 +++++++++++++++++++++++++++++++++----
 t/t7400-submodule-basic.sh | 60 +++++++++++++++++++++++++++++++++++++++
 t/t7403-submodule-sync.sh  | 70 +++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 180 insertions(+), 7 deletions(-)

v4->v5 changes:
       Used test_expect_failure for failing tests.
       Added comments to justify statements.
       Isolated changes to the relative branch.
       Used role-based variable names to help explain transformations.	

-- 
1.7.10.2.649.g5ca7d80

             reply	other threads:[~2012-05-24  3:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24  3:37 Jon Seymour [this message]
2012-05-24  3:37 ` [PATCH v5 1/2] submodule: document failures handling relative superproject origin URLs Jon Seymour
2012-05-24  3:37 ` [PATCH v5 2/2] submodule: fix handling of " Jon Seymour
2012-05-24  3:40   ` Jon Seymour
2012-05-24 18:58   ` Phil Hord
2012-05-24 22:09     ` Jon Seymour
2012-05-24 23:07   ` Jon Seymour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337830657-16400-1-git-send-email-jon.seymour@gmail.com \
    --to=jon.seymour@gmail.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).