From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: Jens.Lehmann@web.de, gitster@pobox.com, phil.hord@gmail.com,
ramsay@ramsay1.demon.co.uk, Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v6 5/9] submodule: extract normalize_path into standalone function
Date: Sun, 27 May 2012 23:43:26 +1000 [thread overview]
Message-ID: <1338126210-11517-6-git-send-email-jon.seymour@gmail.com> (raw)
In-Reply-To: <1338126210-11517-1-git-send-email-jon.seymour@gmail.com>
Extract the normalize_path function so that it can be re-used elsewhere.
Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
git-submodule.sh | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 64a70d6..dbbc905 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -176,6 +176,21 @@ module_clone()
(clear_local_git_env; cd "$sm_path" && GIT_WORK_TREE=. git config core.worktree "$rel/$b")
}
+normalize_path()
+{
+ # normalize path:
+ # multiple //; leading ./; /./; /../; trailing /
+ printf '%s/\n' "$1" |
+ sed -e '
+ s|//*|/|g
+ s|^\(\./\)*||
+ s|/\./|/|g
+ :start
+ s|\([^/]*\)/\.\./||
+ tstart
+ s|/*$||
+ '
+}
#
# Add a new submodule to the working tree, .gitmodules and the index
#
@@ -250,18 +265,7 @@ cmd_add()
;;
esac
- # normalize path:
- # multiple //; leading ./; /./; /../; trailing /
- sm_path=$(printf '%s/\n' "$sm_path" |
- sed -e '
- s|//*|/|g
- s|^\(\./\)*||
- s|/\./|/|g
- :start
- s|\([^/]*\)/\.\./||
- tstart
- s|/*$||
- ')
+ sm_path="$(normalize_path "$sm_path")"
git ls-files --error-unmatch "$sm_path" > /dev/null 2>&1 &&
die "$(eval_gettext "'\$sm_path' already exists in the index")"
--
1.7.10.2.656.gb5a46db
next prev parent reply other threads:[~2012-05-27 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 13:43 [PATCH v6 0/9] submodule: improve robustness of path handling Jon Seymour
2012-05-27 13:43 ` [PATCH v6 1/9] submodule: additional regression tests for relative URLs Jon Seymour
2012-05-27 13:43 ` [PATCH v6 2/9] submodule: document failure to detect invalid submodule URLs Jon Seymour
2012-05-27 13:43 ` [PATCH v6 3/9] submodule: document failure to handle relative superproject origin URLs Jon Seymour
2012-05-27 13:43 ` [PATCH v6 4/9] submodule: document failure to handle improperly normalized remote " Jon Seymour
2012-05-27 13:43 ` Jon Seymour [this message]
2012-05-27 13:43 ` [PATCH v6 6/9] submodule: fix detection of invalid submodule URL Jon Seymour
2012-05-27 13:43 ` [PATCH v6 7/9] submodule: fix sync handling of relative superproject origin URLs Jon Seymour
2012-05-27 13:55 ` Jon Seymour
2012-05-27 13:43 ` [PATCH v6 8/9] submodule: fix handling of denormalized " Jon Seymour
2012-05-27 14:38 ` Jon Seymour
2012-05-27 13:43 ` [PATCH v6 9/9] submodule: fix normalization to handle repeated ./ Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338126210-11517-6-git-send-email-jon.seymour@gmail.com \
--to=jon.seymour@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phil.hord@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).