From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: Jens.Lehmann@web.de, gitster@pobox.com, phil.hord@gmail.com,
ramsay@ramsay1.demon.co.uk, Jon Seymour <jon.seymour@gmail.com>
Subject: [PATCH v7 0/9] submodule: improve robustness of path handling
Date: Mon, 28 May 2012 01:34:02 +1000 [thread overview]
Message-ID: <1338132851-23497-1-git-send-email-jon.seymour@gmail.com> (raw)
This series improves the robustness of path handling by 'git submodule' by:
* detecting submodule URLs that will result in non-sensical submodule origin URLs
* improving handling of various kinds of relative superproject origin URLs
* improving handling of various kinds of denormalized superproject origin URLs
This series differs from v5 in the following ways, by:
* Adding a more extensive set of failure tests to illustrate the conditions
being addressed.
* Modifying the ../ processing loop in resolve_relative_url to exclude the
'invariant' parts of absolute URLs from relative URL processing and thereby
enable earlier and more accurate detection of edits that are going to
produce a non-sensical output.
* Simplifying relative superproject origin URL support, by taking advantage of
the modifications above.
* Adding support for normalizing denormalized superproject origin URLs.
* Adding some additional regression tests to help guard against
unintended regressions by this series.
* Improving the source code comments to better explain the purpose
of various code functions and code blocks
This series differs from v6 by applying the fix in 8/9 to a wider set of tests.
Each patch in the series has been regression tested against the following tests:
t2013-checkout-submodule.sh
t2103-update-index-ignore-missing.sh
t2105-update-index-gitfile.sh
t2201-add-update-typechange.sh
t3000-ls-files-others.sh
t3030-merge-recursive.sh
t3404-rebase-interactive.sh
t4027-diff-submodule.sh
t4041-diff-submodule-option.sh
t4134-apply-submodule.sh
t5526-fetch-submodules.sh
t5531-deep-submodule-push.sh
t6008-rev-list-submodule.sh
t7003-filter-branch.sh
t7400-submodule-basic.sh
t7401-submodule-summary.sh
t7402-submodule-rebase.sh
t7403-submodule-sync.sh
t7405-submodule-merge.sh
t7406-submodule-update.sh
t7407-submodule-foreach.sh
t7408-submodule-reference.sh
t7506-status-submodule.sh
t7508-status.sh
t7610-mergetool.sh
t9300-fast-import.sh
t9350-fast-export.sh
which are the tests that match a grep search for submodule.
Jon Seymour (9):
submodule: additional regression tests for relative URLs
submodule: document failure to detect invalid submodule URLs
submodule: document failure to handle relative superproject origin
URLs
submodule: document failure to handle improperly normalized remote
origin URLs
submodule: extract normalize_path into standalone function
submodule: fix detection of invalid submodule URL
submodule: fix sync handling of relative superproject origin URLs
submodule: fix handling of denormalized superproject origin URLs
submodule: fix normalization to handle repeated ./
git-submodule.sh | 118 +++++++++++++----
t/t7400-submodule-basic.sh | 297 ++++++++++++++++++++++++++++++++++++++++++-
t/t7403-submodule-sync.sh | 97 +++++++++++++-
t/t7406-submodule-update.sh | 16 ++-
t/t7407-submodule-foreach.sh | 14 +-
t/t7506-status-submodule.sh | 10 +-
6 files changed, 504 insertions(+), 48 deletions(-)
--
1.7.10.2.656.g24a6219
next reply other threads:[~2012-05-27 15:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 15:34 Jon Seymour [this message]
2012-05-27 15:34 ` [PATCH v7 1/9] submodule: additional regression tests for relative URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 2/9] submodule: document failure to detect invalid submodule URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 3/9] submodule: document failure to handle relative superproject origin URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 4/9] submodule: document failure to handle improperly normalized remote " Jon Seymour
2012-05-27 15:34 ` [PATCH v7 5/9] submodule: extract normalize_path into standalone function Jon Seymour
2012-05-27 15:34 ` [PATCH v7 6/9] submodule: fix detection of invalid submodule URL Jon Seymour
2012-05-28 19:01 ` Johannes Sixt
2012-05-28 21:39 ` Jon Seymour
2012-06-03 9:51 ` Jon Seymour
2012-05-27 15:34 ` [PATCH v7 7/9] submodule: fix sync handling of relative superproject origin URLs Jon Seymour
2012-05-27 15:34 ` [PATCH v7 8/9] submodule: fix handling of denormalized " Jon Seymour
2012-05-27 22:57 ` Jon Seymour
2012-05-27 15:34 ` [PATCH v7 9/9] submodule: fix normalization to handle repeated ./ Jon Seymour
2012-05-28 20:07 ` [PATCH v7 0/9] submodule: improve robustness of path handling Jens Lehmann
2012-05-28 22:01 ` Jon Seymour
2012-05-29 19:21 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338132851-23497-1-git-send-email-jon.seymour@gmail.com \
--to=jon.seymour@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phil.hord@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).