* [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency
@ 2012-05-31 14:10 Erik Faye-Lund
2012-05-31 19:42 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Erik Faye-Lund @ 2012-05-31 14:10 UTC (permalink / raw)
To: git; +Cc: nickh
In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04),
http.o started recording GIT_VERSION, but http.o wasn't added
to the list of files that depends on GIT-VERSION-FILE.
Fix this, so mofications to GIT-VERSION-FILE will result in an
updated user-agent string.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
I stumbled over this while debugging something related. Perhaps this
fix is worth applying?
There's a similar issue with generation of assembly-listings, but I
figured that was intended for inspection of the generated code; the
version string probably doesn't matter in such cases.
Dunno...
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index c09a679..59e2b25 100644
--- a/Makefile
+++ b/Makefile
@@ -2104,7 +2104,7 @@ configure: configure.ac
$(RM) $<+
# These can record GIT_VERSION
-git.o git.spec \
+git.o git.spec http.o \
$(patsubst %.sh,%,$(SCRIPT_SH)) \
$(patsubst %.perl,%,$(SCRIPT_PERL)) \
: GIT-VERSION-FILE
--
1.7.11.rc0.6836.gdf573d9
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency
2012-05-31 14:10 [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency Erik Faye-Lund
@ 2012-05-31 19:42 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2012-05-31 19:42 UTC (permalink / raw)
To: Erik Faye-Lund; +Cc: git, nickh
Erik Faye-Lund <kusmabite@gmail.com> writes:
> In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04),
> http.o started recording GIT_VERSION, but http.o wasn't added
> to the list of files that depends on GIT-VERSION-FILE.
> ...
> diff --git a/Makefile b/Makefile
> index c09a679..59e2b25 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2104,7 +2104,7 @@ configure: configure.ac
> $(RM) $<+
>
> # These can record GIT_VERSION
> -git.o git.spec \
> +git.o git.spec http.o \
> $(patsubst %.sh,%,$(SCRIPT_SH)) \
> $(patsubst %.perl,%,$(SCRIPT_PERL)) \
> : GIT-VERSION-FILE
Makes sense to me. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-31 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-31 14:10 [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency Erik Faye-Lund
2012-05-31 19:42 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).