From: David Barr <davidbarr@google.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>, David Barr <davidbarr@google.com>
Subject: [PATCH v2 3/6] vcs-svn: prefer constcmp to prefixcmp
Date: Fri, 1 Jun 2012 00:41:27 +1000 [thread overview]
Message-ID: <1338475290-22644-4-git-send-email-davidbarr@google.com> (raw)
In-Reply-To: <1338475290-22644-1-git-send-email-davidbarr@google.com>
Comparisons in svndump.c are always guarded by length.
As a bonus, elimate dependency on prefixcmp for upstream.
Signed-off-by: David Barr <davidbarr@google.com>
---
vcs-svn/svndump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
index 0899790..8d0ae9c 100644
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -361,7 +361,7 @@ void svndump_read(const char *url)
reset_rev_ctx(atoi(val));
break;
case sizeof("Node-path"):
- if (prefixcmp(t, "Node-"))
+ if (constcmp(t, "Node-"))
continue;
if (!constcmp(t + strlen("Node-"), "path")) {
if (active_ctx == NODE_CTX)
--
1.7.10.2
next prev parent reply other threads:[~2012-05-31 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 14:41 [PATCH v2 0/6] vcs-svn: housekeeping David Barr
2012-05-31 14:41 ` [PATCH v2 1/6] vcs-svn: fix clang-analyzer error David Barr
2012-05-31 14:41 ` [PATCH v2 2/6] vcs-svn: simplify cleanup in apply_one_window() David Barr
2012-05-31 14:41 ` David Barr [this message]
2012-06-01 16:27 ` [PATCH v2 3/6] vcs-svn: prefer constcmp to prefixcmp Junio C Hamano
2012-06-01 16:43 ` David Michael Barr
2012-05-31 14:41 ` [PATCH v2 4/6] vcs-svn: prefer strstr over memmem David Barr
2012-05-31 14:41 ` [PATCH v2 5/6] vcs-svn: fix signedness warnings David Barr
2012-05-31 14:41 ` [PATCH v2 6/6] vcs-svn: drop no-op reset methods David Barr
2012-06-01 4:26 ` David Michael Barr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338475290-22644-4-git-send-email-davidbarr@google.com \
--to=davidbarr@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).