git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] t3510 (cherry-pick-sequence): add missing '&&'
@ 2012-06-04 16:42 Ramkumar Ramachandra
  0 siblings, 0 replies; only message in thread
From: Ramkumar Ramachandra @ 2012-06-04 16:42 UTC (permalink / raw)
  To: Git List

Breaks in a test assertion's && chain can potentially hide failures
from earlier commands in the chain.  Fix an instance of this in the
setup.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 Minor nit.  There aren't any other && chaining breakages in the file.

 t/t3510-cherry-pick-sequence.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t3510-cherry-pick-sequence.sh b/t/t3510-cherry-pick-sequence.sh
index 97f3710..f4e6450 100755
--- a/t/t3510-cherry-pick-sequence.sh
+++ b/t/t3510-cherry-pick-sequence.sh
@@ -31,7 +31,7 @@ test_cmp_rev () {
 }
 
 test_expect_success setup '
-	git config advice.detachedhead false
+	git config advice.detachedhead false &&
 	echo unrelated >unrelated &&
 	git add unrelated &&
 	test_commit initial foo a &&
-- 
1.7.10

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-06-04 16:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-04 16:42 [PATCH] t3510 (cherry-pick-sequence): add missing '&&' Ramkumar Ramachandra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).