From: Leila Muhtasib <muhtasib@gmail.com>
To: git@vger.kernel.org
Cc: Leila Muhtasib <muhtasib@gmail.com>
Subject: [PATCH/RFC] Documenation update: use of braces in if/else if/else chain
Date: Sun, 10 Jun 2012 13:26:30 -0400 [thread overview]
Message-ID: <1339349190-84552-1-git-send-email-muhtasib@gmail.com> (raw)
Signed-off-by: Leila Muhtasib <muhtasib@gmail.com>
---
Does the below more accruately represent the coding guidelines?
I can modify it, if it doesn't.
Thanks,
Leila
Documentation/CodingGuidelines | 23 ++++++++++++++++++++---
1 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 4557711..ea90521 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -117,9 +117,26 @@ For C programs:
is frowned upon. A gray area is when the statement extends
over a few lines, and/or you have a lengthy comment atop of
- it. Also, like in the Linux kernel, if there is a long list
- of "else if" statements, it can make sense to add braces to
- single line blocks.
+ it. Also, like in the Linux kernel, if one of the
+ "if/else if/else" chain has a multiple statement block, use {}
+ even for a single statement block in that chain. And "else"
+ should come on the same line as the closing "}" of its "if" block.
+
+ //correct
+ if (bla) {
+ x = 1;
+ ...
+ } else {
+ x = 2;
+ }
+
+ //incorrect
+ if (bla) {
+ x = 1;
+ ...
+ }
+ else
+ x = 2;
- We try to avoid assignments inside if().
--
1.7.7.5 (Apple Git-26)
next reply other threads:[~2012-06-10 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 17:26 Leila Muhtasib [this message]
2012-06-10 20:22 ` [PATCH/RFC] Documenation update: use of braces in if/else if/else chain Jonathan Nieder
2012-06-10 20:52 ` Leila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339349190-84552-1-git-send-email-muhtasib@gmail.com \
--to=muhtasib@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).