From: "David D. Kilzer" <ddkilzer@kilzer.net>
To: git@vger.kernel.org
Cc: gitster@pobox.com, "David D. Kilzer" <ddkilzer@kilzer.net>
Subject: [PATCH] rebase -i -p: use rerere to resolve conflicts if enabled
Date: Fri, 15 Jun 2012 07:17:35 -0700 [thread overview]
Message-ID: <1339769855-94161-1-git-send-email-ddkilzer@kilzer.net> (raw)
From: "David D. Kilzer" <ddkilzer@kilzer.net>
When performing an interactive rebase that preserves merges with
rerere enabled, the --rerere-autoupdate switch should be passed
to git-merge.
Signed-off-by: David D. Kilzer <ddkilzer@kilzer.net>
---
git-rebase--interactive.sh | 7 ++-
t/t3420-rebase-preserve-merges-with-rerere.sh | 75 +++++++++++++++++++++++++
2 files changed, 80 insertions(+), 2 deletions(-)
create mode 100755 t/t3420-rebase-preserve-merges-with-rerere.sh
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 2e13258..958bbf8 100644
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -297,9 +297,12 @@ pick_one_preserving_merges () {
msg_content="$(commit_message $sha1)"
# No point in merging the first parent, that's HEAD
new_parents=${new_parents# $first_parent}
+ # If rerere is enabled, pass the --rerere-autoupdate flag
+ test "$(git config --bool rerere.enabled)" = "true" &&
+ rerere_autoupdate=--rerere-autoupdate || rerere_autoupdate=
if ! do_with_author output \
- git merge --no-ff ${strategy:+-s $strategy} -m \
- "$msg_content" $new_parents
+ git merge --no-ff ${strategy:+-s $strategy} $rerere_autoupdate \
+ -m "$msg_content" $new_parents
then
printf "%s\n" "$msg_content" > "$GIT_DIR"/MERGE_MSG
die_with_patch $sha1 "Error redoing merge $sha1"
diff --git a/t/t3420-rebase-preserve-merges-with-rerere.sh b/t/t3420-rebase-preserve-merges-with-rerere.sh
new file mode 100755
index 0000000..679937d
--- /dev/null
+++ b/t/t3420-rebase-preserve-merges-with-rerere.sh
@@ -0,0 +1,75 @@
+#!/bin/sh
+#
+# Copyright (c) 2007 Johannes E. Schindelin
+# Copyright (c) 2012 David D. Kilzer
+#
+
+test_description='git rebase -i -p should use rerere to resolve conflicts if enabled'
+. ./test-lib.sh
+
+. "$TEST_DIRECTORY"/lib-rebase.sh
+
+set_fake_editor
+
+# Setup
+#
+# A--AA--B <-- master
+# \
+# \
+# \
+# C <-- topic1
+
+test_expect_success 'setup' '
+ test_commit A file1 &&
+ test_commit AA file2 &&
+ test_commit B file1 &&
+ git checkout -b topic1 HEAD^ &&
+ test_commit C file1 &&
+ git checkout master
+'
+
+# Use rerere to resolve conflicts
+#
+# Before interactive rebase:
+#
+# A--AA--B <-- master
+# \ \
+# \ M <-- merge1-baseline, merge1
+# \ /
+# C <-- topic1
+#
+# After interactive rebase:
+#
+# A--AA--B <-- master
+# |\ \
+# | \ M <-- merge1-baseline
+# | \ /
+# | C <-- topic1
+# \ \
+# \ M' <-- merge1
+# \ /
+# B'
+
+test_expect_success 'rebase -i -p uses rerere to resolve conflicts' '
+ git config rerere.enabled true &&
+ git rerere clear &&
+
+ git checkout -b merge1 master &&
+ test_must_fail git merge topic1 &&
+ test "`git rerere status`" = "file1" &&
+ printf "B\nC\n" > file1 &&
+ git add file1 &&
+ git commit -m "M: Merge with conflict resolved." &&
+ git branch merge1-baseline &&
+
+ FAKE_LINES="edit 1 2 3" git rebase -i -p HEAD~2 &&
+ echo BB >> file2 &&
+ git add file2 &&
+ git commit -m "B'\'': Edit file2 to prevent fast-forward." --amend &&
+ test_must_fail git rebase --continue &&
+ git commit -m "M'\'': Merge with conflict resolved by rerere." &&
+ git rebase --continue &&
+ git diff --exit-code merge1-baseline..merge1 file1
+'
+
+test_done
--
1.7.9.6 (Apple Git-31)
next reply other threads:[~2012-06-15 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 14:17 David D. Kilzer [this message]
2012-06-15 15:52 ` [PATCH] rebase -i -p: use rerere to resolve conflicts if enabled Junio C Hamano
2012-06-16 4:08 ` David Kilzer
2012-06-16 5:19 ` Junio C Hamano
2012-06-17 3:58 ` David Kilzer
2012-06-17 5:49 ` Junio C Hamano
2012-06-17 13:46 ` David Kilzer
2012-06-17 18:30 ` Johannes Sixt
2012-06-17 21:30 ` David Kilzer
2012-06-18 19:06 ` Johannes Sixt
2012-06-17 22:00 ` Junio C Hamano
2012-06-17 22:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339769855-94161-1-git-send-email-ddkilzer@kilzer.net \
--to=ddkilzer@kilzer.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).