git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v2 7/9] sha1_name.c: allow get_short_sha1() to take other flags
Date: Wed, 20 Jun 2012 23:35:30 -0700	[thread overview]
Message-ID: <1340260532-11378-8-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1340260532-11378-1-git-send-email-gitster@pobox.com>

Instead of a separate "int quietly" argument, make it take "unsigned flags"
so that we can pass other options to it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 sha1_name.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/sha1_name.c b/sha1_name.c
index 852d5c2..7cca7d9 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -218,13 +218,16 @@ static int finish_object_disambiguation(struct disambiguate_state *ds,
 	return 0;
 }
 
+#define GET_SHORT_QUIETLY 01
+
 static int get_short_sha1(const char *name, int len, unsigned char *sha1,
-			  int quietly)
+			  unsigned flags)
 {
 	int i, status;
 	char hex_pfx[40];
 	unsigned char bin_pfx[20];
 	struct disambiguate_state ds;
+	int quietly = !!(flags & GET_SHORT_QUIETLY);
 
 	if (len < MINIMUM_ABBREV || len > 40)
 		return -1;
@@ -272,7 +275,7 @@ const char *find_unique_abbrev(const unsigned char *sha1, int len)
 		return hex;
 	while (len < 40) {
 		unsigned char sha1_ret[20];
-		status = get_short_sha1(hex, len, sha1_ret, 1);
+		status = get_short_sha1(hex, len, sha1_ret, GET_SHORT_QUIETLY);
 		if (exists
 		    ? !status
 		    : status == SHORT_NAME_NOT_FOUND) {
@@ -603,7 +606,7 @@ static int get_describe_name(const char *name, int len, unsigned char *sha1)
 			if (ch == 'g' && cp[-1] == '-') {
 				cp++;
 				len -= cp - name;
-				return get_short_sha1(cp, len, sha1, 1);
+				return get_short_sha1(cp, len, sha1, GET_SHORT_QUIETLY);
 			}
 		}
 	}
-- 
1.7.11.2.gd284367

  parent reply	other threads:[~2012-06-21  6:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21  6:35 [PATCH v2 0/9] Extending the shelf-life of "git describe" output Junio C Hamano
2012-06-21  6:35 ` [PATCH v2 1/9] sha1_name.c: indentation fix Junio C Hamano
2012-06-21  6:35 ` [PATCH v2 2/9] sha1_name.c: clarify what "fake" is for in find_short_object_filename() Junio C Hamano
2012-06-21  6:35 ` [PATCH v2 3/9] sha1_name.c: rename "now" to "current" Junio C Hamano
2012-06-21  6:35 ` [PATCH v2 4/9] sha1_name.c: refactor find_short_packed_object() Junio C Hamano
2012-06-21  6:35 ` [PATCH v2 5/9] sha1_name.c: correct misnamed "canonical" and "res" Junio C Hamano
2012-06-21  6:35 ` [PATCH v2 6/9] sha1_name.c: restructure disambiguation of short names Junio C Hamano
2012-06-21  6:35 ` Junio C Hamano [this message]
2012-06-21  6:35 ` [PATCH v2 8/9] sha1_name.c: teach get_short_sha1() a commit-only option Junio C Hamano
2012-06-21  6:35 ` [PATCH v2 9/9] sha1_name.c: get_describe_name() by definition groks only commits Junio C Hamano
2012-06-21  9:22   ` Erik Faye-Lund
2012-06-21 19:57     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340260532-11378-8-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).