From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: [PATCH 2/5] git-remote-mediawiki: don't "use encoding 'utf8';" Date: Wed, 27 Jun 2012 11:10:17 +0200 Message-ID: <1340788220-10084-3-git-send-email-Matthieu.Moy@imag.fr> References: <1340726673-25496-1-git-send-email-Matthieu.Moy@imag.fr> <1340788220-10084-1-git-send-email-Matthieu.Moy@imag.fr> Cc: Pavel.Volek@ensimag.imag.fr, Kim-Thuat.Nguyen@ensimag.imag.fr, roucherj@ensimag.imag.fr, Matthieu Moy To: git@vger.kernel.org, gitster@pobox.com X-From: git-owner@vger.kernel.org Wed Jun 27 11:11:41 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SjoHk-0006dM-HO for gcvg-git-2@plane.gmane.org; Wed, 27 Jun 2012 11:11:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755979Ab2F0JLK (ORCPT ); Wed, 27 Jun 2012 05:11:10 -0400 Received: from mx1.imag.fr ([129.88.30.5]:51002 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201Ab2F0JLI (ORCPT ); Wed, 27 Jun 2012 05:11:08 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id q5R99vXx020033 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 27 Jun 2012 11:09:57 +0200 Received: from bauges.imag.fr ([129.88.7.32]) by mail-veri.imag.fr with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SjoGi-0003OD-0U; Wed, 27 Jun 2012 11:10:36 +0200 Received: from moy by bauges.imag.fr with local (Exim 4.72) (envelope-from ) id 1SjoGh-0002dj-Vb; Wed, 27 Jun 2012 11:10:35 +0200 X-Mailer: git-send-email 1.7.11.5.g0c7e058.dirty In-Reply-To: <1340788220-10084-1-git-send-email-Matthieu.Moy@imag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 27 Jun 2012 11:09:57 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: q5R99vXx020033 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr MailScanner-NULL-Check: 1341392997.64586@GlspNoz0QAsxpCyDNwQCkw Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The use of this statement is generally discouraged, and is too intrusive for us: it forces the HTTP requests made by the API to contain only valid UTF-8 characters. This would break the upload of binary files. Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki index 781dfe2..f2e841e 100755 --- a/contrib/mw-to-git/git-remote-mediawiki +++ b/contrib/mw-to-git/git-remote-mediawiki @@ -36,11 +36,10 @@ use strict; use MediaWiki::API; use DateTime::Format::ISO8601; -use encoding 'utf8'; -# use encoding 'utf8' doesn't change STDERROR -# but we're going to output UTF-8 filenames to STDERR +# By default, use UTF-8 to communicate with Git and the user binmode STDERR, ":utf8"; +binmode STDOUT, ":utf8"; use URI::Escape; use IPC::Open2; -- 1.7.11.5.g0c7e058.dirty