From: Namhyung Kim <namhyung@kernel.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH 1/3] gitweb: Get rid of unnecessary check of $signoff
Date: Tue, 3 Jul 2012 15:02:55 +0900 [thread overview]
Message-ID: <1341295377-22083-2-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1341295377-22083-1-git-send-email-namhyung@kernel.org>
If $signoff set to 1, the $line would be handled in
the if statement for the both cases. So the outer of
the conditional always sees the $signoff always set
to 0 and no need to check it. Thus we can finally get
rid of it.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
gitweb/gitweb.perl | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 55e0e9e..7585e08 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4484,27 +4484,20 @@ sub git_print_log {
}
# print log
- my $signoff = 0;
my $empty = 0;
foreach my $line (@$log) {
if ($line =~ m/^ *(signed[ \-]off[ \-]by[ :]|acked[ \-]by[ :]|cc[ :])/i) {
- $signoff = 1;
$empty = 0;
if (! $opts{'-remove_signoff'}) {
print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
- next;
- } else {
- # remove signoff lines
- next;
}
- } else {
- $signoff = 0;
+ next;
}
# print only one empty line
# do not print empty line after signoff
if ($line eq "") {
- next if ($empty || $signoff);
+ next if ($empty);
$empty = 1;
} else {
$empty = 0;
--
1.7.10.2
next prev parent reply other threads:[~2012-07-03 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 6:02 [PATCH 0/3] gitweb changes Namhyung Kim
2012-07-03 6:02 ` Namhyung Kim [this message]
2012-07-03 19:58 ` [PATCH 1/3] gitweb: Get rid of unnecessary check of $signoff Junio C Hamano
2012-07-03 6:02 ` [PATCH 2/3] gitweb: Handle a few other tags in git_print_log Namhyung Kim
2012-07-03 20:05 ` Junio C Hamano
2012-07-03 6:02 ` [PATCH 3/3] gitweb: Add support to Link: tag Namhyung Kim
2012-07-03 20:15 ` Junio C Hamano
2012-07-04 1:24 ` Namhyung Kim
2012-07-04 1:30 ` Namhyung Kim
2012-07-04 1:54 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341295377-22083-2-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).