From: Namhyung Kim <namhyung@kernel.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH 3/3] gitweb: Add support to Link: tag
Date: Tue, 3 Jul 2012 15:02:57 +0900 [thread overview]
Message-ID: <1341295377-22083-4-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1341295377-22083-1-git-send-email-namhyung@kernel.org>
The tip tree is the one of major subsystem tree in the
Linux kernel project. On the tip tree, the Link: tag is
used for tracking the original discussion or context.
Since it's ususally in the s-o-b area, it'd be better
using same style with others.
Also as it tends to contain a message-id sent from git
send-email, a part of the line which has more than 8
(hex-)digit characters would set a wrong hyperlink
like [1]. Fix it by not using format_log_line_html().
[1] git.kernel.org/?p=linux/kernel/git/tip/tip.git;a=commit;h=08942f6d5d992e9486b07653fd87ea8182a22fa0
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
gitweb/gitweb.perl | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index e0701af..d07bcb7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4493,6 +4493,13 @@ sub git_print_log {
print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
}
next;
+ } elsif ($line =~ m,^ *link[ :](http://[\w/~.@%&=?+-]*),i) {
+ $empty = 0;
+ if (! $opts{'-remove_signoff'}) {
+ print "<span class=\"signoff\">Link: <a href=\"" . esc_html($1) . "\">" .
+ esc_html($1) . "</a></span><br/>\n";
+ }
+ next;
}
# print only one empty line
--
1.7.10.2
next prev parent reply other threads:[~2012-07-03 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 6:02 [PATCH 0/3] gitweb changes Namhyung Kim
2012-07-03 6:02 ` [PATCH 1/3] gitweb: Get rid of unnecessary check of $signoff Namhyung Kim
2012-07-03 19:58 ` Junio C Hamano
2012-07-03 6:02 ` [PATCH 2/3] gitweb: Handle a few other tags in git_print_log Namhyung Kim
2012-07-03 20:05 ` Junio C Hamano
2012-07-03 6:02 ` Namhyung Kim [this message]
2012-07-03 20:15 ` [PATCH 3/3] gitweb: Add support to Link: tag Junio C Hamano
2012-07-04 1:24 ` Namhyung Kim
2012-07-04 1:30 ` Namhyung Kim
2012-07-04 1:54 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341295377-22083-4-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).