From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v5 14/25] sha1_name.c: get_sha1_1() takes lookup flags
Date: Tue, 3 Jul 2012 14:37:04 -0700 [thread overview]
Message-ID: <1341351435-31011-15-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1341351435-31011-1-git-send-email-gitster@pobox.com>
This is to pass the disambiguation hints from the caller down the
callchain. Nothing is changed in this step, as everybody just
passes 0 in the flag.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
sha1_name.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/sha1_name.c b/sha1_name.c
index caef6e5..8feb9b5 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -333,7 +333,7 @@ static inline int upstream_mark(const char *string, int len)
return 0;
}
-static int get_sha1_1(const char *name, int len, unsigned char *sha1);
+static int get_sha1_1(const char *name, int len, unsigned char *sha1, unsigned lookup_flags);
static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
{
@@ -370,7 +370,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
ret = interpret_branch_name(str+at, &buf);
if (ret > 0) {
/* substitute this branch name and restart */
- return get_sha1_1(buf.buf, buf.len, sha1);
+ return get_sha1_1(buf.buf, buf.len, sha1, 0);
} else if (ret == 0) {
return -1;
}
@@ -440,7 +440,7 @@ static int get_parent(const char *name, int len,
unsigned char *result, int idx)
{
unsigned char sha1[20];
- int ret = get_sha1_1(name, len, sha1);
+ int ret = get_sha1_1(name, len, sha1, 0);
struct commit *commit;
struct commit_list *p;
@@ -473,7 +473,7 @@ static int get_nth_ancestor(const char *name, int len,
struct commit *commit;
int ret;
- ret = get_sha1_1(name, len, sha1);
+ ret = get_sha1_1(name, len, sha1, 0);
if (ret)
return ret;
commit = lookup_commit_reference(sha1);
@@ -554,7 +554,7 @@ static int peel_onion(const char *name, int len, unsigned char *sha1)
else
return -1;
- if (get_sha1_1(name, sp - name - 2, outer))
+ if (get_sha1_1(name, sp - name - 2, outer, 0))
return -1;
o = parse_object(outer);
@@ -621,7 +621,7 @@ static int get_describe_name(const char *name, int len, unsigned char *sha1)
return -1;
}
-static int get_sha1_1(const char *name, int len, unsigned char *sha1)
+static int get_sha1_1(const char *name, int len, unsigned char *sha1, unsigned lookup_flags)
{
int ret, has_suffix;
const char *cp;
@@ -1098,7 +1098,7 @@ static int get_sha1_with_context_1(const char *name, unsigned char *sha1,
memset(oc, 0, sizeof(*oc));
oc->mode = S_IFINVALID;
- ret = get_sha1_1(name, namelen, sha1);
+ ret = get_sha1_1(name, namelen, sha1, 0);
if (!ret)
return ret;
/* sha1:path --> object name of path in ent sha1
@@ -1176,7 +1176,7 @@ static int get_sha1_with_context_1(const char *name, unsigned char *sha1,
strncpy(object_name, name, cp-name);
object_name[cp-name] = '\0';
}
- if (!get_sha1_1(name, cp-name, tree_sha1)) {
+ if (!get_sha1_1(name, cp-name, tree_sha1, 0)) {
const char *filename = cp+1;
char *new_filename = NULL;
--
1.7.11.1.229.g706c98f
next prev parent reply other threads:[~2012-07-03 21:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 21:36 [PATCH v5 00/25] Extending the shelf-life of "git describe" output Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 01/25] sha1_name.c: indentation fix Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 02/25] sha1_name.c: hide get_sha1_with_context_1() ugliness Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 03/25] sha1_name.c: get rid of get_sha1_with_mode_1() Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 04/25] sha1_name.c: get rid of get_sha1_with_mode() Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 05/25] sha1_name.c: clarify what "fake" is for in find_short_object_filename() Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 06/25] sha1_name.c: rename "now" to "current" Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 07/25] sha1_name.c: refactor find_short_packed_object() Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 08/25] sha1_name.c: correct misnamed "canonical" and "res" Junio C Hamano
2012-07-03 21:36 ` [PATCH v5 09/25] sha1_name.c: restructure disambiguation of short names Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 10/25] get_sha1(): fix error status regression Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 11/25] sha1_name.c: allow get_short_sha1() to take other flags Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 12/25] sha1_name.c: teach get_short_sha1() a commit-only option Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 13/25] sha1_name.c: get_describe_name() by definition groks only commits Junio C Hamano
2012-07-03 21:37 ` Junio C Hamano [this message]
2012-07-03 21:37 ` [PATCH v5 15/25] sha1_name.c: many short names can only be committish Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 16/25] sha1_name.c: teach lookup context to get_sha1_with_context() Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 17/25] sha1_name.c: introduce get_sha1_committish() Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 18/25] revision.c: allow handle_revision_arg() to take other flags Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 19/25] revision.c: the "log" family, except for "show", takes committish Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 20/25] sha1_name.c: add support for disambiguating other types Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 21/25] apply: --build-fake-ancestor expects blobs Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 22/25] commit-tree: the command wants a tree and commits Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 23/25] reset: the command takes committish Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 24/25] rev-parse: A and B in "rev-parse A..B" refer to committish Junio C Hamano
2012-07-03 21:37 ` [PATCH v5 25/25] rev-parse --disambiguate=<prefix> Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341351435-31011-15-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).