From: Namhyung Kim <namhyung@kernel.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH v2 3/3] gitweb: Add support to Link: tag
Date: Wed, 4 Jul 2012 11:47:26 +0900 [thread overview]
Message-ID: <1341370046-19913-3-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1341370046-19913-1-git-send-email-namhyung@kernel.org>
The tip tree is the one of major subsystem tree in the
Linux kernel project. On the tip tree, the Link: (or
similar Buglink:) tag is used for tracking the original
discussion or context. Since it's ususally in the S-o-b
area, it'd be better using same style with others.
Also as it tends to contain a message-id sent from git
send-email, a part of the line would set a wrong hyperlink
like [1]. Fix it by not using format_log_line_html().
[1] git.kernel.org/?p=linux/kernel/git/tip/tip.git;a=commit;h=08942f6d5d992e9486b07653fd87ea8182a22fa0
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
gitweb/gitweb.perl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 362784d..3d6a705 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4494,6 +4494,16 @@ sub git_print_log {
next;
}
+ if ($line =~ m,\s*([a-z]*link): (https?://\S+),i) {
+ if (! $opts{'-remove_signoff'}) {
+ print "<span class=\"signoff\">" . esc_html($1) . ": " .
+ "<a href=\"" . esc_html($2) . "\">" . esc_html($2) . "</a>" .
+ "</span><br/>\n";
+ $skip_blank_line = 1;
+ }
+ next;
+ }
+
# print only one empty line
# do not print empty line after signoff
if ($line eq "") {
--
1.7.10.4
next prev parent reply other threads:[~2012-07-04 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 2:47 [PATCH v2 1/3] gitweb: Cleanup git_print_log() Namhyung Kim
2012-07-04 2:47 ` [PATCH v2 2/3] gitweb: Handle other types of tag in git_print_log Namhyung Kim
2012-07-04 2:47 ` Namhyung Kim [this message]
2012-07-05 22:29 ` [PATCH v2 3/3] gitweb: Add support to Link: tag Junio C Hamano
2012-07-05 22:22 ` [PATCH v2 1/3] gitweb: Cleanup git_print_log() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341370046-19913-3-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).