From: Thomas Gummerer <t.gummerer@gmail.com>
To: git@vger.kernel.org
Cc: trast@student.ethz.ch, gitster@pobox.com, mhagger@alum.mit.edu,
pclouds@gmail.com, t.gummerer@gmail.com
Subject: Introduction of a ce_namelen field
Date: Fri, 6 Jul 2012 18:07:28 +0200 [thread overview]
Message-ID: <1341590850-15653-1-git-send-email-t.gummerer@gmail.com> (raw)
In-Reply-To: <7vtxxns4z4.fsf@alter.siamese.dyndns.org>
Thanks to the review of Junio, Duy and Thomas here is a reroll of the
patches, where the name length is separated from the flags in the
in-memory format and which includes a little bit of a performance
optimization by using the ce_namelen field instead of strlen() in
a couple of places thanks to the suggestion of Duy.
[PATCH/RFC v2 1/2] Strip namelen out of ce_flags into a ce_namelen
[PATCH/RFC v2 2/2] Replace strlen(ce->name) with ce_namlen
builtin/apply.c | 3 ++-
builtin/blame.c | 3 ++-
builtin/checkout.c | 3 ++-
builtin/update-index.c | 9 ++++++---
cache.h | 18 ++++++------------
read-cache.c | 58 +++++++++++++++++++++++++++++++++++-----------------------
tree.c | 7 ++++---
unpack-trees.c | 5 +++--
8 files changed, 60 insertions(+), 46 deletions(-)
next prev parent reply other threads:[~2012-07-06 16:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 9:18 [PATCH/RFC] Replace ce_namelen() with a ce_namelen field Thomas Gummerer
2012-07-04 10:00 ` Thomas Rast
2012-07-04 10:01 ` Nguyen Thai Ngoc Duy
2012-07-04 10:07 ` Nguyen Thai Ngoc Duy
2012-07-04 19:26 ` Junio C Hamano
2012-07-06 16:07 ` Thomas Gummerer [this message]
2012-07-06 16:07 ` [PATCH/RFC v2 1/2] Strip namelen out of ce_flags into " Thomas Gummerer
2012-07-09 4:59 ` Junio C Hamano
2012-07-11 9:22 ` [PATCH v3 0/3] Introduction of " Thomas Gummerer
2012-07-11 9:22 ` [PATCH v3 1/3] read-cache.c: Handle long filenames correctly Thomas Gummerer
2012-07-11 11:34 ` Nguyen Thai Ngoc Duy
2012-07-11 16:33 ` Junio C Hamano
2012-07-11 9:22 ` [PATCH v3 2/3] Strip namelen out of ce_flags into a ce_namelen field Thomas Gummerer
2012-07-11 9:22 ` [PATCH v3 3/3] Replace strlen() with ce_namelen() Thomas Gummerer
2012-07-11 16:35 ` Junio C Hamano
2012-07-11 16:29 ` [PATCH/RFC v2 1/2] Strip namelen out of ce_flags into a ce_namelen field Junio C Hamano
2012-07-06 16:07 ` [PATCH/RFC v2 2/2] Replace strlen() with ce_namelen() Thomas Gummerer
2012-07-09 2:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341590850-15653-1-git-send-email-t.gummerer@gmail.com \
--to=t.gummerer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).