git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH v4 02/19] apply: a bit more comments on PATH_TO_BE_DELETED
Date: Tue, 10 Jul 2012 00:03:55 -0700	[thread overview]
Message-ID: <1341903852-4815-3-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1341903852-4815-1-git-send-email-gitster@pobox.com>

The code is littered with to_be_deleted() whose purpose is not so clear.
Describe where it matters.  Also remove an extra space before "#define"
that snuck in by mistake at 7fac0ee (builtin-apply: keep information about
files to be deleted, 2009-04-11).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/apply.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/builtin/apply.c b/builtin/apply.c
index 44f6de9..35460c9 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -2970,9 +2970,15 @@ static struct patch *in_fn_table(const char *name)
  * item->util in the filename table records the status of the path.
  * Usually it points at a patch (whose result records the contents
  * of it after applying it), but it could be PATH_WAS_DELETED for a
- * path that a previously applied patch has already removed.
+ * path that a previously applied patch has already removed, or
+ * PATH_TO_BE_DELETED for a path that a later patch would remove.
+ *
+ * The latter is needed to deal with a case where two paths A and B
+ * are swapped by first renaming A to B and then renaming B to A;
+ * moving A to B should not be prevented due to presense of B as we
+ * will remove it in a later patch.
  */
- #define PATH_TO_BE_DELETED ((struct patch *) -2)
+#define PATH_TO_BE_DELETED ((struct patch *) -2)
 #define PATH_WAS_DELETED ((struct patch *) -1)
 
 static int to_be_deleted(struct patch *patch)
-- 
1.7.11.1.294.g68a9409

  parent reply	other threads:[~2012-07-10  7:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  7:03 [PATCH v4 00/19] "git apply --3way" Junio C Hamano
2012-07-10  7:03 ` [PATCH v4 01/19] apply: fix an incomplete comment in check_patch() Junio C Hamano
2012-07-10  7:03 ` Junio C Hamano [this message]
2012-07-10  7:03 ` [PATCH v4 03/19] apply: clear_image() clears things a bit more Junio C Hamano
2012-07-10  7:03 ` [PATCH v4 04/19] apply: refactor read_file_or_gitlink() Junio C Hamano
2012-07-10  7:03 ` [PATCH v4 05/19] apply: factor out checkout_target() helper function Junio C Hamano
2012-07-10  7:03 ` [PATCH v4 06/19] apply: split load_preimage() helper function out Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 07/19] apply: refactor "previous patch" logic Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 08/19] apply: further split load_preimage() Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 09/19] apply: move check_to_create_blob() closer to its sole caller Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 10/19] apply: move "already exists" logic to check_to_create() Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 11/19] apply: accept -3/--3way command line option Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 12/19] apply: fall back on three-way merge Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 13/19] apply: plug the three-way merge logic in Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 14/19] apply: move verify_index_match() higher Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 15/19] apply: --3way with add/add conflict Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 16/19] apply: register conflicted stages to the index Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 17/19] apply: allow rerere() to work on --3way results Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 18/19] apply: document --3way option Junio C Hamano
2012-07-10  7:04 ` [PATCH v4 19/19] apply: tests for the " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341903852-4815-3-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).