From: Ralf Thielow <ralf.thielow@gmail.com>
To: trast@student.ethz.ch
Cc: git@vger.kernel.org, gitster@pobox.com,
Ralf Thielow <ralf.thielow@gmail.com>
Subject: [PATCH] merge-recursive: add hint for translators in handle_change_delete()
Date: Sun, 5 Aug 2012 19:55:32 +0200 [thread overview]
Message-ID: <1344189332-27082-1-git-send-email-ralf.thielow@gmail.com> (raw)
The outputs in handle_change_delete() contain a lot of placeholders.
This could end up in confusion to translators since two parts of them
are translated separately. Add a hint for translators that they can
easily understand it without study the code.
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
---
This patch is based on a confusion on my own of the values of the
replacements. The first idea of Thomas was to remove the legos of
the static replacements. After thinking about and trying, it would
end up in a lot more of lines in this function mainly caused by the
different outputs. It might be nicer to just add a hint for translators
to describe the static replacements.
merge-recursive.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/merge-recursive.c b/merge-recursive.c
index 8903a73..7f661f2 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -1035,6 +1035,9 @@ static void handle_change_delete(struct merge_options *o,
update_file(o, 0, o_sha, o_mode, renamed ? renamed : path);
} else if (!a_sha) {
if (!renamed) {
+ /* TRANSLATORS: The first %s will be "rename" or "modify",
+ the fourth %s will be "renamed" or "modified". These replacements
+ are translated separately. This counts for the next four messages. */
output(o, 1, _("CONFLICT (%s/delete): %s deleted in %s "
"and %s in %s. Version %s of %s left in tree."),
change, path, o->branch1, change_past,
--
1.7.12.rc1
next reply other threads:[~2012-08-05 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 17:55 Ralf Thielow [this message]
2012-08-05 20:03 ` [PATCH] merge-recursive: add hint for translators in handle_change_delete() Junio C Hamano
2012-08-06 18:03 ` [PATCHv2] " Ralf Thielow
2012-08-06 19:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344189332-27082-1-git-send-email-ralf.thielow@gmail.com \
--to=ralf.thielow@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).