git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ralf Thielow <ralf.thielow@gmail.com>
To: gitster@pobox.com
Cc: trast@student.ethz.ch, git@vger.kernel.org,
	Ralf Thielow <ralf.thielow@gmail.com>
Subject: [PATCHv2] merge-recursive: add hint for translators in handle_change_delete()
Date: Mon,  6 Aug 2012 20:03:44 +0200	[thread overview]
Message-ID: <1344276224-11876-1-git-send-email-ralf.thielow@gmail.com> (raw)
In-Reply-To: <1344189332-27082-1-git-send-email-ralf.thielow@gmail.com>

The outputs in handle_change_delete() contain a lot of placeholders.
This could end up in confusion to translators. Add a hint for translators
that they can easily understand it without study the code.

Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
---
The first version did only explain the first and the
fourth placeholder. Junio pointed out that the others
could still confuse translators. This second version
explains now all placeholders. It differs to Junio's
suggestion in a modified header and an optional part
for the other messages.

 merge-recursive.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/merge-recursive.c b/merge-recursive.c
index 8903a73..ca58dcd 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -1035,6 +1035,20 @@ static void handle_change_delete(struct merge_options *o,
 		update_file(o, 0, o_sha, o_mode, renamed ? renamed : path);
 	} else if (!a_sha) {
 		if (!renamed) {
+			/*
+			 * TRANSLATORS: The next four messages have many
+			 * placeholders.
+			 *
+			 * CONFLICT (
+			 * %s=<translation of noun "rename" or "modify">/delete):
+			 * %s=<name of the path being merged> deleted in
+			 * %s=<name of a branch> and
+			 * %s=<translation of verb pp "renamed" or "modified"> in
+			 * %s=<name of a branch>. Version
+			 * %s=<name of a branch> of
+			 * %s=<name of the path being merged> left in tree[.][at
+			 * %s=<name of the path beeing merged was renamed to>.]
+			 */
 			output(o, 1, _("CONFLICT (%s/delete): %s deleted in %s "
 			       "and %s in %s. Version %s of %s left in tree."),
 			       change, path, o->branch1, change_past,
-- 
1.7.12.rc1

  parent reply	other threads:[~2012-08-06 18:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-05 17:55 [PATCH] merge-recursive: add hint for translators in handle_change_delete() Ralf Thielow
2012-08-05 20:03 ` Junio C Hamano
2012-08-06 18:03 ` Ralf Thielow [this message]
2012-08-06 19:07   ` [PATCHv2] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344276224-11876-1-git-send-email-ralf.thielow@gmail.com \
    --to=ralf.thielow@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).