From: Ben Walton <bwalton@artsci.utoronto.ca>
To: git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Cc: rctay89@gmail.com, schwab@linux-m68k.org,
Ben Walton <bwalton@artsci.utoronto.ca>
Subject: [PATCH] Enable HAVE_DEV_TTY for Solaris
Date: Mon, 6 Aug 2012 23:07:42 -0400 [thread overview]
Message-ID: <1344308862-24635-1-git-send-email-bwalton@artsci.utoronto.ca> (raw)
In-Reply-To: <20120807003541.GA18219@sigill.intra.peff.net>
Now that git_terminal_prompt can cleanly interact with /dev/tty on
Solaris, enable HAVE_DEV_TTY so that this code path is used for
credential reading instead of relying on the crippled getpass().
Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
---
This is a follow up to Jeff's patch that fixes git_terminal_prompt on
Solaris. I don't have 5.6 or 5.7 for testing but I believe this
should be valid for both of those releases as well.
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 15d1319..6b0c961 100644
--- a/Makefile
+++ b/Makefile
@@ -1014,6 +1014,7 @@ ifeq ($(uname_S),SunOS)
NO_REGEX = YesPlease
NO_FNMATCH_CASEFOLD = YesPlease
NO_MSGFMT_EXTENDED_OPTIONS = YesPlease
+ HAVE_DEV_TTY = YesPlease
ifeq ($(uname_R),5.6)
SOCKLEN_T = int
NO_HSTRERROR = YesPlease
--
1.7.10.3
next prev parent reply other threads:[~2012-08-07 3:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 23:17 [PATCH] Avoid crippled getpass function on Solaris Ben Walton
2012-08-06 1:56 ` Tay Ray Chuan
2012-08-06 2:41 ` Ben Walton
2012-08-06 1:59 ` Junio C Hamano
2012-08-06 2:35 ` Ben Walton
2012-08-06 19:39 ` Jeff King
2012-08-06 19:57 ` Junio C Hamano
2012-08-06 21:31 ` Ben Walton
2012-08-06 21:34 ` Jeff King
2012-08-06 22:09 ` Ben Walton
2012-08-06 22:31 ` Jeff King
2012-08-06 22:39 ` Ben Walton
2012-08-06 22:42 ` Jeff King
2012-08-06 23:31 ` Ben Walton
2012-08-07 0:01 ` Jeff King
2012-08-06 23:05 ` Andreas Schwab
2012-08-07 0:23 ` Jeff King
2012-08-07 0:35 ` Jeff King
2012-08-07 2:18 ` Tay Ray Chuan
2012-08-07 3:01 ` Ben Walton
2012-08-07 3:07 ` Ben Walton [this message]
2012-08-07 3:43 ` [PATCH] Enable HAVE_DEV_TTY for Solaris Junio C Hamano
2012-08-07 4:03 ` Jeff King
2012-08-07 4:10 ` Jeff King
2012-08-07 15:31 ` Ben Walton
2012-08-08 14:13 ` Erik Faye-Lund
2012-08-08 21:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344308862-24635-1-git-send-email-bwalton@artsci.utoronto.ca \
--to=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rctay89@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).