git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Tom Xue <tomxue0126@gmail.com>
Subject: [PATCH 0/2] relative future date
Date: Thu, 16 Aug 2012 16:02:01 -0700	[thread overview]
Message-ID: <1345158123-22189-1-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1341505087-13632-1-git-send-email-tomxue0126@gmail.com>

Jundong Xue <tomxue0126@gmail.com> writes:

> tomxue@ubuntu:~/mycode/life$ git todo
> * d768da9 - (in the future: 3 hours later) Meeting with vendor
> * 5fcd556 - (in the future: 12 days later) Take my personal ho
> * 9dd280b - (in the future: 11 months later)
> * 4680099 - (in the future: 9 months later)
> * 59d5266 - (in the future: 8 months later)
> * b5308da - (in the future: 7 months later)
> ...

I was re-reading the backlog and after looking at it again, I do not
think what the patch tries to do is a bad thing per-se.  There are
changes I want to see _how_ it is done, though.

Especially, the duplication of the exact same logic in the future
and in the past was an unmaintainable mess.

Here is an attempt to clean it up.

Opinions?  If the list finds this is a worthwhile thing to do (I am
neutral), it needs help from i18n people to mark format messages up
properly again.

Thanks.

Junio C Hamano (2):
  date: refactor the relative date logic from presentation
  date: show relative dates in the future

 date.c          | 187 +++++++++++++++++++++++++++++++++++++++++++-------------
 t/t0006-date.sh |   2 +
 2 files changed, 146 insertions(+), 43 deletions(-)

-- 
1.7.12.rc3.69.gaf0166d

  parent reply	other threads:[~2012-08-16 23:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 16:18 [PATCH] Can show relative date of the commit with future timestamp Tom Xue
2012-07-05 17:26 ` Junio C Hamano
     [not found]   ` <CA+P7oHuCbeJ5shfL5OVhSypgygzmQwn-RGPD8UvFUFuqnoV9fA@mail.gmail.com>
2012-07-06  8:15     ` Jundong Xue
2012-08-20 22:51       ` Junio C Hamano
2012-08-21  9:17         ` Jundong Xue
2012-08-16 23:02 ` Junio C Hamano [this message]
2012-08-16 23:02   ` [PATCH 1/2] date: refactor the relative date logic from presentation Junio C Hamano
2012-08-16 23:02   ` [PATCH 2/2] date: show relative dates in the future Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345158123-22189-1-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=tomxue0126@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).