From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
git@vger.kernel.org, Orgad and Raizel Shaneh <orgads@gmail.com>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH v2 2/8] t0060: verify that absolute_path() fails if passed the empty string
Date: Fri, 7 Sep 2012 00:40:58 +0200 [thread overview]
Message-ID: <1346971264-23744-3-git-send-email-mhagger@alum.mit.edu> (raw)
In-Reply-To: <1346971264-23744-1-git-send-email-mhagger@alum.mit.edu>
It doesn't, so mark the test as failing.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
t/t0060-path-utils.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh
index c8db144..d91e516 100755
--- a/t/t0060-path-utils.sh
+++ b/t/t0060-path-utils.sh
@@ -140,6 +140,10 @@ test_expect_success 'strip_path_suffix' '
c:/msysgit/libexec//git-core libexec/git-core)
'
+test_expect_failure 'absolute path rejects the empty string' '
+ test_must_fail test-path-utils absolute_path ""
+'
+
test_expect_success SYMLINKS 'real path works as expected' '
mkdir first &&
ln -s ../.git first/.git &&
--
1.7.11.3
next prev parent reply other threads:[~2012-09-06 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 22:40 [PATCH v2 0/8] Fix some bugs in abspath.c Michael Haggerty
2012-09-06 22:40 ` [PATCH v2 1/8] t0060: move tests of real_path() from t0000 to here Michael Haggerty
2012-09-06 22:40 ` Michael Haggerty [this message]
2012-09-06 22:40 ` [PATCH v2 3/8] absolute_path(): reject the empty string Michael Haggerty
2012-09-06 23:09 ` Junio C Hamano
2012-09-09 4:48 ` Michael Haggerty
2012-09-09 4:59 ` Junio C Hamano
2012-09-06 22:41 ` [PATCH v2 4/8] t0060: verify that real_path() fails if passed " Michael Haggerty
2012-09-06 22:41 ` [PATCH v2 5/8] real_path(): reject " Michael Haggerty
2012-09-06 22:41 ` [PATCH v2 6/8] t0060: verify that real_path() works correctly with absolute paths Michael Haggerty
2012-09-06 22:41 ` [PATCH v2 7/8] real_path(): properly handle nonexistent top-level paths Michael Haggerty
2012-09-06 22:41 ` [PATCH v2 8/8] t0060: verify that real_path() removes extra slashes Michael Haggerty
2012-09-09 15:42 ` [PATCH 9/8] t0060: split absolute path test in two to exercise some of it on Windows Johannes Sixt
2012-09-10 11:52 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346971264-23744-3-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=orgads@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).