From: David Aguilar <davvid@gmail.com>
To: Paul Mackerras <paulus@samba.org>, Junio C Hamano <gitster@pobox.com>
Cc: Tim McCormack <cortex@brainonfire.net>, git@vger.kernel.org
Subject: [PATCH] gitk: Rename 'tagcontents' to 'cached_tagcontent'
Date: Sat, 8 Sep 2012 12:53:16 -0700 [thread overview]
Message-ID: <1347133996-70908-1-git-send-email-davvid@gmail.com> (raw)
In-Reply-To: <1347130993-69863-1-git-send-email-davvid@gmail.com>
Name the 'tagcontents' variable similarly to the rest of the
variables cleared in the changedrefs() function.
This makes the naming consistent and provides a hint that it
should be cleared when reloading gitk's cache.
Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Follow-up to 'gitk: Teach "Reread references" to reload tags'
gitk | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/gitk b/gitk
index a124822..6f24f53 100755
--- a/gitk
+++ b/gitk
@@ -10599,7 +10599,7 @@ proc movedhead {hid head} {
}
proc changedrefs {} {
- global cached_dheads cached_dtags cached_atags tagcontents
+ global cached_dheads cached_dtags cached_atags cached_tagcontent
global arctags archeads arcnos arcout idheads idtags
foreach id [concat [array names idheads] [array names idtags]] {
@@ -10611,7 +10611,7 @@ proc changedrefs {} {
}
}
}
- catch {unset tagcontents}
+ catch {unset cached_tagcontent}
catch {unset cached_dtags}
catch {unset cached_atags}
catch {unset cached_dheads}
@@ -10664,7 +10664,7 @@ proc listrefs {id} {
}
proc showtag {tag isnew} {
- global ctext tagcontents tagids linknum tagobjid
+ global ctext cached_tagcontent tagids linknum tagobjid
if {$isnew} {
addtohistory [list showtag $tag 0] savectextpos
@@ -10673,13 +10673,13 @@ proc showtag {tag isnew} {
clear_ctext
settabs 0
set linknum 0
- if {![info exists tagcontents($tag)]} {
+ if {![info exists cached_tagcontent($tag)]} {
catch {
- set tagcontents($tag) [exec git cat-file tag $tag]
+ set cached_tagcontent($tag) [exec git cat-file tag $tag]
}
}
- if {[info exists tagcontents($tag)]} {
- set text $tagcontents($tag)
+ if {[info exists cached_tagcontent($tag)]} {
+ set text $cached_tagcontent($tag)
} else {
set text "[mc "Tag"]: $tag\n[mc "Id"]: $tagids($tag)"
}
--
1.7.7.2.448.gee6df
next prev parent reply other threads:[~2012-09-08 19:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 18:17 gitk does not reload tag messages Tim McCormack
2012-09-07 3:08 ` David Aguilar
2012-09-07 5:18 ` Junio C Hamano
2012-09-08 19:03 ` [PATCH] gitk: Teach "Reread references" to reload tags David Aguilar
2012-09-08 19:53 ` David Aguilar [this message]
2012-09-09 5:11 ` [PATCH] gitk: Rename 'tagcontents' to 'cached_tagcontent' Junio C Hamano
2012-09-12 9:25 ` Junio C Hamano
2012-09-12 12:37 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347133996-70908-1-git-send-email-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=cortex@brainonfire.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).